From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] sensor-detect and non-compliant SMSC Super I/Os
Date: Tue, 12 Jun 2007 20:36:05 +0000 [thread overview]
Message-ID: <20070612223605.141ad100@hyperion.delvare> (raw)
In-Reply-To: <191fb4ca0706111131w61cc4abfo31ba33bba90a3314@mail.gmail.com>
On Mon, 11 Jun 2007 21:54:50 +0200, Hans de Goede wrote:
> Juerg Haefliger wrote:
> > All,
> >
> > I looked through a lot of SMSC datasheets the last couple of days with
> > the goal to improve sensor-detect to correctly identify more SMSC
> > Super I/Os. I noticed that some of the chips don't conform to the ISA
> > PNP standard with the device ID register living at a different address
> > (0x0d instead of 0x20). In order to correctly identify those chips, a
> > somewhat ugly (and totally SMSC specific) hack would be necessary.
> > Something like reading from both addresses and then using the value
> > from 0x0d for some of the SMSC chips.
> >
> > I wonder how much value this adds given that none of these Super IOs
> > have HW monitoring capabilities? The only benefit I can see is that
> > the chip is correctly identified and we can flag it as not being a
> > sensor and thus users won't bug us for adding support.
> >
> > Any thoughts, comments, ideas?
> >
>
> I think that if the hack isn't too gross, it would be good to also be able to
> identify those chips.
Same for me, it depends on how the code looks like. If it's clean and
safe, no objection.
I am curious how you can tell between the two types of register
mappings? Is there a perfect solution, or do you have some heuristic?
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-06-12 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-11 18:31 [lm-sensors] sensor-detect and non-compliant SMSC Super I/Os Juerg Haefliger
2007-06-11 19:54 ` Hans de Goede
2007-06-12 20:36 ` Jean Delvare [this message]
2007-06-14 19:26 ` Juerg Haefliger
2007-06-16 9:18 ` Jean Delvare
2007-06-18 3:59 ` Juerg Haefliger
2007-06-18 8:29 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070612223605.141ad100@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.