From: Sam Ravnborg <sam@ravnborg.org>
To: Satyam Sharma <satyam.sharma@gmail.com>
Cc: Jan Beulich <jbeulich@novell.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org, patches@x86-64.org
Subject: Re: [PATCH] x86: fix improper .init-type section references
Date: Wed, 13 Jun 2007 06:35:26 +0200 [thread overview]
Message-ID: <20070613043526.GA20088@uranus.ravnborg.org> (raw)
In-Reply-To: <a781481a0706122018i6273cd17y61cd95e269b5c7c9@mail.gmail.com>
>
> Yup, we were only discussing possibility that modpost not complain
> about .init -> .exit references that will never go oops (because the arch
> guarantees that).
And there are no good reasosns why the rules should be different for i386
and powerpc.
This type of special casing is always bad.
Think about it a little.
Someone writes a generic driver and test it on i386 - OK.
But for powerpc it result in a build failure. It would be so much better
to warn about this situation early.
We had this exact issue in loop.c recently - so it is not a made up example.
[I recall it was ia64 that had a build failure but the example still holds ture]
Sam
next prev parent reply other threads:[~2007-06-13 4:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 7:48 [PATCH] x86: fix improper .init-type section references Jan Beulich
2007-06-12 11:14 ` Satyam Sharma
2007-06-12 12:09 ` Satyam Sharma
2007-06-12 12:43 ` Jan Beulich
2007-06-12 13:32 ` Satyam Sharma
2007-06-12 13:49 ` Jan Beulich
2007-06-12 14:09 ` Satyam Sharma
2007-06-12 18:00 ` Sam Ravnborg
2007-06-13 3:18 ` Satyam Sharma
2007-06-13 4:35 ` Sam Ravnborg [this message]
2007-06-13 6:59 ` Jan Beulich
2007-06-13 7:39 ` Satyam Sharma
2007-06-13 7:49 ` Jan Beulich
2007-06-13 8:10 ` Sam Ravnborg
2007-06-12 17:56 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070613043526.GA20088@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=ak@suse.de \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@x86-64.org \
--cc=satyam.sharma@gmail.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.