All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Meelis Roos <mroos@linux.ee>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Wang Zhenyu <zhenyu.z.wang@intel.com>,
	Eric Anholt <eric@anholt.net>
Subject: Re: I815 suddenly unkown to agpgart?
Date: Wed, 13 Jun 2007 12:15:13 -0400	[thread overview]
Message-ID: <20070613161513.GE3875@redhat.com> (raw)
In-Reply-To: <20070613160152.GC3875@redhat.com>

On Wed, Jun 13, 2007 at 12:01:52PM -0400, Dave Jones wrote:
 > On Wed, Jun 13, 2007 at 06:07:42PM +0300, Meelis Roos wrote:
 >  > agpgart: Unsupported Intel chipset(device id: 1130)
 > 
 > This is likely due to 9614ece14f23f2ce54a076c471aec9c91e51e79c
 > 
 >     [AGPGART] intel_agp: use table for device probe
 >     
 >     Fixed issues noted by Christoph Hellwig, and I changed device table
 >     scan a bit to allow the case that some models of graphics chips may
 >     have same host bridge type. This type of chip will be added in the future.
 >     
 >     This patch cleans up device probe function. Eric Anholt was the original author.
 > 
 > Eric ?

Oh, we have this check in find_gmch ..

        if (gmch_device && PCI_FUNC(gmch_device->devfn) != 0) {
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Which isn't going to work, as Meelis has a gmch on device0, slot0, devfn1.
Meelis, does it start working again if you change that to just

	if (gmch_Device) {

?

	Dave

-- 
http://www.codemonkey.org.uk

  reply	other threads:[~2007-06-13 16:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13 15:07 I815 suddenly unkown to agpgart? Meelis Roos
2007-06-13 16:01 ` Dave Jones
2007-06-13 16:15   ` Dave Jones [this message]
2007-06-13 17:59     ` Meelis Roos
2007-06-13 18:00     ` Wang Zhenyu
2007-06-13 18:19       ` Meelis Roos
2007-06-13 18:22       ` Dave Jones
2007-06-14  1:34         ` Wang Zhenyu
2007-06-14  2:01           ` Wang Zhenyu
2007-06-14  6:03             ` Meelis Roos
2007-06-14 22:09             ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070613161513.GE3875@redhat.com \
    --to=davej@redhat.com \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=zhenyu.z.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.