All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux@fluff.org>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, Vincent Sanders <vince@simtec.co.uk>,
	Ben Dooks <ben-linux@fluff.org>
Subject: [patch 2/6] SM501: initialise SDRAM clock before bus clocks
Date: Thu, 14 Jun 2007 11:01:11 +0100	[thread overview]
Message-ID: <20070614100135.887605502@fluff.org.uk> (raw)
In-Reply-To: 20070614100109.192172553@fluff.org.uk

[-- Attachment #1: simtec-drivers-mfd-sm501-clock-order.patch --]
[-- Type: text/plain, Size: 1299 bytes --]

This init sequence of setting the SDRAM clock before the
bus clock is recommend by Silicon Motion to stop problems
with writes not sticking into registers.

Signed-off-by: Vincent Sanders <vince@simtec.co.uk>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>

Index: linux-2.6.21-quilt8/drivers/mfd/sm501.c
===================================================================
--- linux-2.6.21-quilt8.orig/drivers/mfd/sm501.c	2007-06-07 12:12:38.000000000 +0100
+++ linux-2.6.21-quilt8/drivers/mfd/sm501.c	2007-06-07 12:13:03.000000000 +0100
@@ -833,15 +833,15 @@ static void sm501_init_regs(struct sm501
 	sm501_init_reg(sm, SM501_GPIO31_0_CONTROL, &init->gpio_low);
 	sm501_init_reg(sm, SM501_GPIO63_32_CONTROL, &init->gpio_high);
 
-	if (init->mclk) {
-		dev_info(sm->dev, "setting MCLK to %ld\n", init->mclk);
-		sm501_set_clock(sm->dev, SM501_CLOCK_MCLK, init->mclk);
-	}
-
 	if (init->m1xclk) {
 		dev_info(sm->dev, "setting M1XCLK to %ld\n", init->m1xclk);
 		sm501_set_clock(sm->dev, SM501_CLOCK_M1XCLK, init->m1xclk);
 	}
+
+	if (init->mclk) {
+		dev_info(sm->dev, "setting MCLK to %ld\n", init->mclk);
+		sm501_set_clock(sm->dev, SM501_CLOCK_MCLK, init->mclk);
+	}
 }
 
 static unsigned int sm501_mem_local[] = {

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

  parent reply	other threads:[~2007-06-14 10:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-14 10:01 [patch 0/6] SM501 fixes and updates Ben Dooks
2007-06-14 10:01 ` [patch 1/6] SM501: suspend support Ben Dooks
2007-06-14 10:01 ` Ben Dooks [this message]
2007-06-14 10:01 ` [patch 3/6] SM501: Fix sm501_init_reg() mask/set order Ben Dooks
2007-06-14 10:01 ` [patch 4/6] SM501: Clock updates and checks Ben Dooks
2007-06-14 10:01 ` [patch 5/6] SM501: Add Documentation/SM501.txt Ben Dooks
2007-06-14 10:01 ` [patch 6/6] SM501: Check SM501 ID register on initialisation Ben Dooks
2007-06-14 11:22 ` [patch 0/6] SM501 fixes and updates Sam Ravnborg
2007-06-14 12:51   ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070614100135.887605502@fluff.org.uk \
    --to=ben-linux@fluff.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vince@simtec.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.