From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [patch 2.6.23-pre] s/SENSORS_/HWMON_/ in Kconfig,
Date: Thu, 14 Jun 2007 18:26:28 +0000 [thread overview]
Message-ID: <20070614202628.6cb1b8f5@hyperion.delvare> (raw)
In-Reply-To: <466E2E83.4010203@gmail.com>
Hi Jim,
On Mon, 11 Jun 2007 23:26:27 -0600, Jim Cromie wrote:
>
> (patch attached, with this stuff at the top - hope thats ok)
>
> This changes SENSORS to HWMON in Kconfig and Makefile,
> which makes it agree with 'menuconfig HWMON' at the top of Kconfig,
> and with the dir-name itself. ISTM that theres no reason
> (save legacy) to keep this arbitrary difference.
>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> ---
> [jimc@harpo hwmon-stuff]$ diffstat diff.conf-sensors-2-hwmon
> Kconfig | 110 +++++++++++++++++++++++++++++++--------------------------------
> Makefile | 102 +++++++++++++++++++++++++++++-----------------------------
> 2 files changed, 106 insertions(+), 106 deletions(-)
Thinking about it some more, I found 2 problems with your patch:
* It breaks the ams driver:
$ grep -r CONFIG_SENSORS drivers/hwmon/ams
drivers/hwmon/ams/ams-core.c:#ifdef CONFIG_SENSORS_AMS_I2C
drivers/hwmon/ams/ams-core.c:#ifdef CONFIG_SENSORS_AMS_PMU
drivers/hwmon/ams/Makefile:ams-$(CONFIG_SENSORS_AMS_PMU) += ams-pmu.o
drivers/hwmon/ams/Makefile:ams-$(CONFIG_SENSORS_AMS_I2C) += ams-i2c.o
drivers/hwmon/ams/Makefile:obj-$(CONFIG_SENSORS_AMS) += ams.o
drivers/hwmon/ams/ams.h:#ifdef CONFIG_SENSORS_AMS_I2C
You need to update these too.
* It breaks a lot of default configurations:
$ quilt grep CONFIG_SENSORS arch | wc -l
2729
A number of these are for the drivers/i2c/chips part of your patch.
So this will be a much bigger patch than you originally posted.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-06-14 18:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 5:26 [lm-sensors] [patch 2.6.23-pre] s/SENSORS_/HWMON_/ in Kconfig, Jim Cromie
2007-06-12 11:23 ` Mark M. Hoffman
2007-06-12 20:44 ` Jean Delvare
2007-06-13 17:52 ` Jim Cromie
2007-06-14 18:26 ` Jean Delvare [this message]
2007-06-14 20:56 ` Jim Cromie
2007-06-15 18:20 ` Jean Delvare
2007-06-16 3:14 ` Mark M. Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070614202628.6cb1b8f5@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.