All of lore.kernel.org
 help / color / mirror / Atom feed
From: rmccabe@sourceware.org <rmccabe@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] conga/ricci/modules/storage LV.cpp
Date: 14 Jun 2007 22:14:26 -0000	[thread overview]
Message-ID: <20070614221426.9545.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	conga
Branch: 	EXPERIMENTAL
Changes by:	rmccabe at sourceware.org	2007-06-14 22:14:26

Modified files:
	ricci/modules/storage: LV.cpp 

Log message:
	Don't hose clustered filesystems that may be mounted on other nodes when attempting to remove a clustered LV.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/ricci/modules/storage/LV.cpp.diff?cvsroot=cluster&only_with_tag=EXPERIMENTAL&r1=1.8&r2=1.8.2.1

--- conga/ricci/modules/storage/LV.cpp	2007/03/05 20:45:17	1.8
+++ conga/ricci/modules/storage/LV.cpp	2007/06/14 22:14:25	1.8.2.1
@@ -246,12 +246,14 @@
 LV::remove()
 {
   // if VG is marked as clustered, but cluster locking is not available, throw
-  if (_props.get("clustered").get_bool() &&
-      !LVM::clustered_enabled())
-    throw LVMClusterLockingError();
-  
-  content->remove();
-  LVM::lvremove(path());
+	bool lv_clustered = _props.get("clustered").get_bool();
+	if (lv_clustered && !LVM::clustered_enabled())
+		throw LVMClusterLockingError();
+
+	/* Don't hose volumes that may be mounted elsewhere */
+	if (!lv_clustered)
+		content->remove();
+	LVM::lvremove(path());
 }
 
 



             reply	other threads:[~2007-06-14 22:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-14 22:14 rmccabe [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-06-15 15:30 [Cluster-devel] conga/ricci/modules/storage LV.cpp rmccabe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070614221426.9545.qmail@sourceware.org \
    --to=rmccabe@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.