From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [ANNOUNCE] Btrfs: a copy on write, snapshotting FS Date: Fri, 15 Jun 2007 16:51:40 -0400 Message-ID: <20070615205140.GV2061@think.oraclecorp.com> References: <20070612161029.GB28279@think.oraclecorp.com> <467188F6.7020002@gmail.com> <20070614191331.GE2061@think.oraclecorp.com> <4672E3B6.1030000@gmail.com> <20070615191153.GU2061@think.oraclecorp.com> <4672FA8C.50309@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: "Florian D." Return-path: Received: from rgminet01.oracle.com ([148.87.113.118]:35822 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755590AbXFOUzG (ORCPT ); Fri, 15 Jun 2007 16:55:06 -0400 Content-Disposition: inline In-Reply-To: <4672FA8C.50309@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jun 15, 2007 at 10:46:04PM +0200, Florian D. wrote: > Chris Mason wrote: > >> # umount /mnt/temp/ > >> > >> [ 457.980372] ------------[ cut here ]------------ > >> [ 457.980377] kernel BUG at fs/buffer.c:2644! > > > > Whoops. Please try this: [ bad patch ] > sorry, with the patch applied: > > [ 147.475077] BUG: at > /home/florian/system/btrfs_test/btrfs-0.2/disk-io.c:534 Well, apparently I get get the silly stuff wrong an infinite number of times. Sorry, lets try again: diff -r 38b36aaaa731 disk-io.c --- a/disk-io.c Fri Jun 15 13:50:20 2007 -0400 +++ b/disk-io.c Fri Jun 15 16:52:38 2007 -0400 @@ -541,6 +541,8 @@ int write_ctree_super(struct btrfs_trans else ret = submit_bh(WRITE, bh); if (ret == -EOPNOTSUPP) { + get_bh(bh); + lock_buffer(bh); set_buffer_uptodate(bh); root->fs_info->do_barriers = 0; ret = submit_bh(WRITE, bh);