From: Arnd Bergmann <arnd@arndb.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dave Airlie <airlied@linux.ie>,
linux-arch@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Introduce compat_u64 and compat_s64 types
Date: Sat, 16 Jun 2007 12:26:40 +0200 [thread overview]
Message-ID: <200706161226.40875.arnd@arndb.de> (raw)
In-Reply-To: <1181986686.25228.639.camel@pmac.infradead.org>
On Saturday 16 June 2007, David Woodhouse wrote:
> Will GCC know that it needs to emit code to handle that (mis)alignment?
I've tested this with gcc-4.0.3, and it does the right thing, which
is to split a 4 byte aligned 64 bit load/store into two 32 bit accesses,
if you pass -mstrict-align.
> Preliminary tests show that it does load the value bytewise if we use
> the 'packed' attribute structure on ppc64, but doesn't if we use
> compat_u64. But then, I don't think it actually _needs_ to handle it n
> ppc64 anyway, so maybe that's not such a good test.
Right. Note that the behaviour of compat_u64 is the same as when you
pass attribute((packed,aligned(4))) to the structure, where it also won't
do byte accesses, and split the 64 bit access only if you pass
-mstrict-align.
Arnd <><
next prev parent reply other threads:[~2007-06-16 10:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200706150159.l5F1xNgM000459@hera.kernel.org>
2007-06-15 8:44 ` drm: fix radeon setparam on 32/64 bit systems David Woodhouse
2007-06-15 8:58 ` Benjamin Herrenschmidt
2007-06-15 9:28 ` Arnd Bergmann
2007-06-15 9:31 ` [PATCH] Introduce compat_u64 and compat_s64 types Arnd Bergmann
2007-06-15 9:55 ` David Miller
2007-06-15 11:55 ` Andi Kleen
2007-06-15 12:00 ` David Woodhouse
2007-06-15 12:38 ` Andi Kleen
2007-06-15 12:03 ` Arnd Bergmann
2007-06-15 12:40 ` Andi Kleen
2007-06-15 12:47 ` David Woodhouse
2007-06-15 13:19 ` Benjamin Herrenschmidt
2007-06-15 12:09 ` David Howells
2007-06-15 12:43 ` Andi Kleen
2007-06-15 12:54 ` Alan Cox
2007-06-15 12:54 ` Andi Kleen
2007-06-15 13:15 ` Alan Cox
2007-06-15 13:27 ` Andi Kleen
2007-06-15 13:32 ` David Woodhouse
2007-06-15 20:50 ` Robin Getz
2007-06-15 21:22 ` Andi Kleen
2007-06-16 8:31 ` David Woodhouse
2007-06-15 13:00 ` David Woodhouse
2007-06-15 12:11 ` Matthew Wilcox
2007-06-15 12:38 ` David Woodhouse
2007-06-15 12:42 ` Arnd Bergmann
2007-06-15 13:45 ` Matthew Wilcox
2007-06-15 13:52 ` Arnd Bergmann
2007-06-15 23:54 ` Benjamin Herrenschmidt
2007-06-15 13:16 ` Benjamin Herrenschmidt
2007-06-16 9:38 ` David Woodhouse
2007-06-16 10:26 ` Arnd Bergmann [this message]
2007-06-16 11:21 ` Arnd Bergmann
2007-06-16 11:34 ` David Woodhouse
2007-06-16 13:56 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706161226.40875.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=dwmw2@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.