All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thiemo Seufer <ths@networkno.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH][UPDATED] Fix path mangling in linux-user/path.c
Date: Sun, 17 Jun 2007 17:30:52 +0100	[thread overview]
Message-ID: <20070617163052.GA19155@networkno.de> (raw)
In-Reply-To: <53fbb7580705211623n3c0c3bf2x9e68842fc25a43be@mail.gmail.com>

Lauri Leukkunen wrote:
> Attached patch fixes the linux-user path mangling code for use with
> real target root filesystems that have nasty symlinks and lots of
> files. The old code is terribly slow and can easily end up going
> through the entire host system /usr hierarchy in a recursive loop.
> 
> Compared to the previous version of this patch, fixes an issue with
> attempting to free() a pointer returned by GNU basename().

I gave it a try, and found:
  - It loses the path caching (which should be done incrementally to
    avoid the slowness you observe)
  - It misses to do error handling on malloc() returns
  - It is broken, an emulated "/bin/ls /.." shows it ascends above
    the root.


Thiemo

  parent reply	other threads:[~2007-06-17 16:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-21 23:23 [Qemu-devel] [PATCH][UPDATED] Fix path mangling in linux-user/path.c Lauri Leukkunen
2007-05-22  6:08 ` Kirill A. Shutemov
2007-05-22  7:16   ` Lauri Leukkunen
2007-06-17 16:30 ` Thiemo Seufer [this message]
2007-06-18  6:02   ` Lauri Leukkunen
2007-06-18 20:36     ` Lauri Leukkunen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070617163052.GA19155@networkno.de \
    --to=ths@networkno.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.