From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [patch 5/6] ps3: ROM Storage Driver Date: Tue, 19 Jun 2007 07:51:58 +0200 Message-ID: <20070619055158.GC18542@lst.de> References: <20070615113919.142332000@pademelon.sonytel.be> <20070615120848.454492000@pademelon.sonytel.be> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.210]:36261 "EHLO mail.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753947AbXFSFw1 (ORCPT ); Tue, 19 Jun 2007 01:52:27 -0400 Content-Disposition: inline In-Reply-To: <20070615120848.454492000@pademelon.sonytel.be> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Geert Uytterhoeven Cc: Paul Mackerras , linuxppc-dev@ozlabs.org, Jens Axboe , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Looks pretty nice. Some more comments: - no need for the BLK_DEV_SR dependency, it should depend on SCSI instead (which might be implied by beeing in the scsi menu, don't remember that detail) - ps3rom_priv should probably be an inline - the cmd field in struct ps3rom_private should probably be renamed to curr_cmd or something along the line to make sure this is the current command we deal with and the driver can only deal with one command at a time. - The comment in ps3rom_queuecommand should explain why we prefer lv1_storage_{read,write} over just sending down the scsi cdb, not just that we prefer it. - I don't think you need to decode the 6 byte commands at all, ATAPI only has the 10 byte variants and you can tell the scsi layer not to ever send the 6 byte ones by setting the use_10_for_rw flag in ->slave_configure - same comment about the free_irq/request_irq pair as in the disk driver. - please use the new shost_priv helper in scsi-misc for accessing the hostdata file in struct Scsi_Host so that the ugly casts can go away. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lst.de (verein.lst.de [213.95.11.210]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 439D4DDF10 for ; Tue, 19 Jun 2007 15:52:02 +1000 (EST) Date: Tue, 19 Jun 2007 07:51:58 +0200 From: Christoph Hellwig To: Geert Uytterhoeven Subject: Re: [patch 5/6] ps3: ROM Storage Driver Message-ID: <20070619055158.GC18542@lst.de> References: <20070615113919.142332000@pademelon.sonytel.be> <20070615120848.454492000@pademelon.sonytel.be> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070615120848.454492000@pademelon.sonytel.be> Cc: Jens Axboe , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Looks pretty nice. Some more comments: - no need for the BLK_DEV_SR dependency, it should depend on SCSI instead (which might be implied by beeing in the scsi menu, don't remember that detail) - ps3rom_priv should probably be an inline - the cmd field in struct ps3rom_private should probably be renamed to curr_cmd or something along the line to make sure this is the current command we deal with and the driver can only deal with one command at a time. - The comment in ps3rom_queuecommand should explain why we prefer lv1_storage_{read,write} over just sending down the scsi cdb, not just that we prefer it. - I don't think you need to decode the 6 byte commands at all, ATAPI only has the 10 byte variants and you can tell the scsi layer not to ever send the 6 byte ones by setting the use_10_for_rw flag in ->slave_configure - same comment about the free_irq/request_irq pair as in the disk driver. - please use the new shost_priv helper in scsi-misc for accessing the hostdata file in struct Scsi_Host so that the ugly casts can go away.