Re: [PATCH] Quota netlink interface

[Jan Kara <jack@suse.cz>]

On Mon 18-06-07 12:01:03, Randy Dunlap wrote:
> On Mon, 18 Jun 2007 14:14:55 +0200 Jan Kara wrote:
> 
> >   Hello,
> > 
> >   I've written a patch implementing quota netlink interface. Whenever some
> > event happens (like user exceeding softlimit), a message is sent to
> > userpace. Then, in userspace we can decide what to do with the message -
> > print it to console, show a dialog or whatever... I've also written a new
> > daemon that listens to netlink and sends the received message to DBus and/or
> > to the console the user has last written to.
> >   If somebody is interested in trying it out, he can checkout latest
> > quota-tools CVS and I can provide him with the modified libnl providing
> > better support for generic netlink handling.
> 
> 
> +config QUOTA_NETLINK_INTERFACE
> +	bool "Report quota messages through netlink interface"
> +	depends on QUOTA
> +	select NET
> +	help
> +	  If you say Y here, quota warnings (about exceeding softlimit, reaching
> +	  hardlimit, etc.) will be reported through netlink interface. If unsure,
> +	  say Y.
> 
> 
> Using "select" is either evil or OK, but only OK for "library-type" code.
> It should never be used to pull in a complete subsystem like NET does
> (even though SCSI_NETLINK does this same thing, sadly).
  OK, I can make it 'depends on NET' instead. I guess it's no problem in
this case since whoever wants quota is going to have NET enabled.
  The problem I sometimes have with 'depends on' is that the option is
invisible until you have enabled all the dependencies so it's hard to
  a) find out that there exists and interesting feature (because it depends
on something you are not used to turn on).
  b) you know the feature exists but you have to dig in Kconfigs to find out
what you have to enable first...

  Maybe we could improve Kconfig to support other type of dependency that
shows you the option even if these dependencies are not satisfied (probably in
some other color) but allows you to only view help and unresolved
dependencies...

									Honza
-- 
Jan Kara <jack@suse.cz>
SuSE CR Labs