From: Rodolfo Giometti <giometti@enneenne.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Trilok Soni <soni.trilok@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
i2c@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [i2c] [PATCH] I2C: TSL2550 support.
Date: Tue, 19 Jun 2007 15:51:02 +0200 [thread overview]
Message-ID: <20070619135102.GH4374@enneenne.com> (raw)
In-Reply-To: <20070619153940.0e120fb0@hyperion.delvare>
On Tue, Jun 19, 2007 at 03:39:40PM +0200, Jean Delvare wrote:
> Hi Rodolfo,
>
> On Tue, 19 Jun 2007 14:10:20 +0200, Rodolfo Giometti wrote:
> > Add support for Taos TSL2550 ambient light sensors.
> > (http://www.taosinc.com/product_detail.asp?cateid=4&proid=18).
> >
> > Signed-off-by: Rodolfo Giometti <giometti@linux.it>
>
> Did you ever read my review of your driver?
> http://lists.lm-sensors.org/pipermail/i2c/2007-February/000824.html
No! I missed it!
> I'm asking because you never replied and I don't see any of my
> suggestions implemented in this new version of your driver.
I'm very sorry for that... :'(
Let me fix your suggestions and I send again my patch.
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@gnudd.com
Embedded Systems giometti@linux.it
UNIX programming phone: +39 349 2432127
next prev parent reply other threads:[~2007-06-19 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 10:55 [PATCH] I2C: TSL2550 support Rodolfo Giometti
2007-06-19 11:28 ` Trilok Soni
2007-06-19 12:10 ` Rodolfo Giometti
2007-06-19 13:39 ` [i2c] " Jean Delvare
2007-06-19 13:51 ` Rodolfo Giometti [this message]
2007-06-19 14:47 ` Rodolfo Giometti
2007-06-20 9:45 ` Jean Delvare
2007-06-19 14:48 ` [i2c] " Rodolfo Giometti
2007-06-20 9:38 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070619135102.GH4374@enneenne.com \
--to=giometti@enneenne.com \
--cc=akpm@linux-foundation.org \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=soni.trilok@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.