From: Jens Axboe <jens.axboe@oracle.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Paul Bristow <paul@paulbristow.net>,
Dave Gilbert <linux@treblig.org>,
Russell King <rmk@arm.linux.org.uk>,
Dave Alan Gilbert <gilbertd@cs.man.ac.uk>,
Paul Clements <Paul.Clements@steeleye.com>,
Pavel Machek <pavel@suse.cz>,
Steven Whitehouse <swhiteho@redhat.com>,
Eberhard Moenkeberg <emoenke@gwdg.de>,
David van Leeuwen <avid@tm.tno.nl>,
Oliver Raupach <raupach@nwfs1.rz.fh-hannover.de>,
Heiko Schlittermann <heiko@lotte.sax.de>,
Leo Spiekman <spiekman@dutette.et.tudelft.nl>,
"Vadim V. Model" <model@cecmow.enet.dec.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] fix req->cmd == INT cases
Date: Tue, 19 Jun 2007 19:16:11 +0200 [thread overview]
Message-ID: <20070619171610.GH18863@kernel.dk> (raw)
In-Reply-To: <4677FD50.2090803@panasas.com>
On Tue, Jun 19 2007, Boaz Harrosh wrote:
> From 6f4641911701cbdbe01516305b682012d8c6982a Mon Sep 17 00:00:00 2001
> Date: Tue, 19 Jun 2007 18:54:54 +0300
>
> I have unearthed very old bugs in stale drivers that still
> used request->cmd as a READ|WRITE int.
> This patch is maybe a proof that these drivers have not been
> used for a long time. Should they be removed completely?
If you look at most of the code, it's inside ifdef debug statements or
comments most of them. So I don't think you can base any removal
suggestion on that.
The patch itself looks fine though, if you send one that isn't mangled
I'll apply it to the 2.6.23 branch.
--
Jens Axboe
next prev parent reply other threads:[~2007-06-19 17:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 15:59 [PATCH] fix req->cmd == INT cases Boaz Harrosh
2007-06-19 17:16 ` Jens Axboe [this message]
2007-06-20 10:53 ` Boaz Harrosh
2007-06-20 10:59 ` Jens Axboe
2007-06-20 11:31 ` Boaz Harrosh
2007-06-20 12:22 ` Christoph Hellwig
2007-06-20 12:24 ` Jens Axboe
2007-06-20 12:26 ` Christoph Hellwig
2007-06-20 21:16 ` Rene Herman
2007-06-21 6:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070619171610.GH18863@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=Paul.Clements@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=avid@tm.tno.nl \
--cc=bharrosh@panasas.com \
--cc=emoenke@gwdg.de \
--cc=gilbertd@cs.man.ac.uk \
--cc=heiko@lotte.sax.de \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@treblig.org \
--cc=model@cecmow.enet.dec.com \
--cc=paul@paulbristow.net \
--cc=pavel@suse.cz \
--cc=raupach@nwfs1.rz.fh-hannover.de \
--cc=rmk@arm.linux.org.uk \
--cc=spiekman@dutette.et.tudelft.nl \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.