From: Ralf Baechle <ralf@linux-mips.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Marc St-Jean <stjeanma@pmc-sierra.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH 7/12] drivers: PMC MSP71xx GPIO char driver
Date: Wed, 20 Jun 2007 09:05:14 +0100 [thread overview]
Message-ID: <20070620080514.GA24818@linux-mips.org> (raw)
In-Reply-To: <20070619141256.3d573a41.akpm@linux-foundation.org>
On Tue, Jun 19, 2007 at 02:12:56PM -0700, Andrew Morton wrote:
> > +/* Define the following for extra debug output */
> > +#undef DEBUG
>
> The under shouldn't be needed: -DDEBUG can be provided on the kbuild
> command line.
>
> > +#ifdef DEBUG
> > +#define DBG(args...) printk(KERN_DEBUG args)
> > +#else
> > +#define DBG(args...) do {} while (0)
> > +#endif
<linux/kernel.h> provides the equivalent pr_debug function so this
definition of DBG is redundant.
Ralf
next prev parent reply other threads:[~2007-06-20 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 20:46 [PATCH 7/12] drivers: PMC MSP71xx GPIO char driver Marc St-Jean
2007-06-19 21:12 ` Andrew Morton
2007-06-20 8:05 ` Ralf Baechle [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-06-20 22:54 Marc St-Jean
2007-06-20 0:27 Marc St-Jean
2007-06-20 3:25 ` Andrew Morton
2007-04-27 20:05 Marc St-Jean
2007-03-26 22:00 Marc St-Jean
2007-03-16 21:39 Marc St-Jean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070620080514.GA24818@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mips@linux-mips.org \
--cc=stjeanma@pmc-sierra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.