From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1I12Fe-0002Fg-AC for user-mode-linux-devel@lists.sourceforge.net; Wed, 20 Jun 2007 08:37:46 -0700 Received: from [198.99.130.12] (helo=saraswathi.solana.com) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1I12Fc-0007sN-Qm for user-mode-linux-devel@lists.sourceforge.net; Wed, 20 Jun 2007 08:37:46 -0700 Date: Wed, 20 Jun 2007 11:37:32 -0400 From: Jeff Dike Message-ID: <20070620153732.GC6728@c2.user-mode-linux.org> References: <20070619184245.GA10567@c2.user-mode-linux.org> <20070619115422.de61abd5.akpm@linux-foundation.org> <20070619195003.GA11718@c2.user-mode-linux.org> <20070619125707.84cf73fd.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <20070619125707.84cf73fd.randy.dunlap@oracle.com> Subject: Re: [uml-devel] [PATCH 2/2] UML - Add stack usage monitoring List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Randy Dunlap Cc: Andrew Morton , LKML , uml-devel On Tue, Jun 19, 2007 at 12:57:07PM -0700, Randy Dunlap wrote: > Kconfig help text is indented 2 more spaces (by convention or > CodingStyle). OK, will fix. > > + if(*p != 0) > > if (*p != NULL) p is int *, so that's a int version pointer comparision. > or > if (*p) Conceptually, p is an int, not a boolean, so I prefer to type the extra characters to do the int-to-boolean conversion in places that want booleans. > > + if (left < lowest_to_date) { > > + printk("Greatest stack depth - %d bytes left\n", left); > > Does UML need/use KERN_* facility levels in printk() calls? Yes, will fix. Jeff -- Work email - jdike at linux dot intel dot com ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754836AbXFTPh7 (ORCPT ); Wed, 20 Jun 2007 11:37:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752731AbXFTPhw (ORCPT ); Wed, 20 Jun 2007 11:37:52 -0400 Received: from saraswathi.solana.com ([198.99.130.12]:57300 "EHLO saraswathi.solana.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752616AbXFTPhv (ORCPT ); Wed, 20 Jun 2007 11:37:51 -0400 Date: Wed, 20 Jun 2007 11:37:32 -0400 From: Jeff Dike To: Randy Dunlap Cc: Andrew Morton , LKML , uml-devel Subject: Re: [PATCH 2/2] UML - Add stack usage monitoring Message-ID: <20070620153732.GC6728@c2.user-mode-linux.org> References: <20070619184245.GA10567@c2.user-mode-linux.org> <20070619115422.de61abd5.akpm@linux-foundation.org> <20070619195003.GA11718@c2.user-mode-linux.org> <20070619125707.84cf73fd.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070619125707.84cf73fd.randy.dunlap@oracle.com> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 19, 2007 at 12:57:07PM -0700, Randy Dunlap wrote: > Kconfig help text is indented 2 more spaces (by convention or > CodingStyle). OK, will fix. > > + if(*p != 0) > > if (*p != NULL) p is int *, so that's a int version pointer comparision. > or > if (*p) Conceptually, p is an int, not a boolean, so I prefer to type the extra characters to do the int-to-boolean conversion in places that want booleans. > > + if (left < lowest_to_date) { > > + printk("Greatest stack depth - %d bytes left\n", left); > > Does UML need/use KERN_* facility levels in printk() calls? Yes, will fix. Jeff -- Work email - jdike at linux dot intel dot com