All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] Running Protocol C with disk cache enabled
Date: Wed, 20 Jun 2007 18:31:20 +0200	[thread overview]
Message-ID: <20070620163120.GC24827@ogo.aicooma.com> (raw)
In-Reply-To: <200706201533.14467.philipp.reisner@linbit.com>

On Wed, Jun 20, 2007 at 03:33:14PM +0200, Philipp Reisner wrote:
> > However - there is one case that I don't think is covered currently;
> > it's entirely possible that I'm missing something, but I wanted to
> > check; the case in question is if the Secondary system suffers an
> > unexpected power loss, therebye potentially losing some writes that were
> > acknowledged prior to the failure. Now, I think that the activity log
> > maintained by the Primary actually includes the necessary information
> > about blocks which should be resynchronized _but_ I don't see any code
> > that would actually add these blocks to the bitmap when such a failure
> > occurs.
> >
> 
> Right we do not do this. The current opinion on this is: If the
> disk reported IO completion it has to be on disk. (actually a point
> of view of the Linux-2.2 and Linux-2.4 time).

Me and Phil had a few words about this.

Now, lying hardware is sooo broken :(
but, anyways.

the most easy way to realise this workaround
in current drbd apears to be:
 upon attach, always apply the activity log, 
 unless known to have been cleanly shut down.

we would basically maintain the activity log on the secondary
as well, and introduce an additional "cleanly detached" flag.

whenever you attach it again, the extents covered would need to be
resynced.  obviously this behaviour should be configurable, you want to
disable it for good hardware and large activity log.

I can think of few possible optimizations, even...
but we should not over-engineer what is "just" a workaround.

> further comments and opinions welcome of course!

-- 
: Lars Ellenberg                            Tel +43-1-8178292-0  :
: LINBIT Information Technologies GmbH      Fax +43-1-8178292-82 :
: Vivenotgasse 48, A-1120 Vienna/Europe    http://www.linbit.com :

  reply	other threads:[~2007-06-20 16:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19 15:16 [Drbd-dev] Running Protocol C with disk cache enabled Graham, Simon
2007-06-20 13:33 ` Philipp Reisner
2007-06-20 16:31   ` Lars Ellenberg [this message]
2007-06-20 19:47   ` Graham, Simon
2007-06-21 13:26     ` Lars Ellenberg
2007-06-22 18:41       ` Philipp Reisner
2007-06-22 20:03       ` Graham, Simon
2007-06-22 20:09       ` Graham, Simon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070620163120.GC24827@ogo.aicooma.com \
    --to=lars.ellenberg@linbit.com \
    --cc=drbd-dev@lists.linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.