From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] bcm43xx: honour promisc bit even in monitor mode
Date: Wed, 20 Jun 2007 23:01:25 +0200 [thread overview]
Message-ID: <200706202301.25890.mb@bu3sch.de> (raw)
In-Reply-To: <1182295838.3714.14.camel@johannes.berg>
On Wednesday 20 June 2007 01:30:38 Johannes Berg wrote:
> When bcm43xx goes into monitor mode, it always is a promisc monitor
> mode. For the hostapd using monitor interfaces, we'll want to only go
> into monitor mode if it's really required. I previously thought that
> this requires changes to mac80211, but mac80211 does in fact already
> seem to handle IFF_PROMISC appropriately. Hence, this change is the
> only required to get proper semantics for a monitor interface that
> isn't in promiscuous mode on bcm43xx.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>
> ---
> Since wireshark/tcpdump by default still set IFF_PROMISC everything will
> work just fine, but if somebody really wants a monitor interface that
> isn't promisc this makes it work too. However, you'll of course get all
> packets still if any other interface is set promisc. We don't do any
> promisc/non-promisc filtering in the stack when multiple monitor
> interfaces are open.
Applied, thanks.
--
Greetings Michael.
prev parent reply other threads:[~2007-06-20 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 23:30 [PATCH] bcm43xx: honour promisc bit even in monitor mode Johannes Berg
2007-06-20 21:01 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706202301.25890.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.