From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-gui: use "blame -w -C -C" for "where did it come from, originally?"
Date: Thu, 21 Jun 2007 01:01:17 -0400 [thread overview]
Message-ID: <20070621050117.GF8477@spearce.org> (raw)
In-Reply-To: <7vk5tx5333.fsf@assigned-by-dhcp.pobox.com>
Junio C Hamano <gitster@pobox.com> wrote:
> The blame window shows "who wrote the piece originally" and "who
> moved it there" in two columns. In order to identify the former
> more correctly, it helps to use the new -w option.
...
> diff --git a/lib/blame.tcl b/lib/blame.tcl
> index 139171d..a412a8c 100644
> --- a/lib/blame.tcl
> +++ b/lib/blame.tcl
> @@ -672,7 +672,7 @@ method _read_blame {fd cur_w cur_d cur_s} {
> close $fd
> if {$cur_w eq $w_asim} {
> _exec_blame $this $w_amov @amov_data \
> - [list -M -C -C] \
> + [list -w -C -C] \
> { original location}
> } else {
> set current_fd {}
>
I've wanted to do this since you introduced `git blame -w`. But I
can't use it, because I cannot trust that -w is there. For example
it is not in maint, but the new blame viewer from git-gui is.
Apply my --list-features patch to core Git and I'll activate -w in
git-gui when --list-features claims the 'blame-ignore-whitespace'
feature is available.
;-)
--
Shawn.
next prev parent reply other threads:[~2007-06-21 5:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-16 22:26 [PATCH] Cloning from a repo without "current branch" Nanako Shiraishi
2007-06-17 3:41 ` Junio C Hamano
2007-06-20 21:50 ` Nanako Shiraishi
2007-06-20 22:29 ` Junio C Hamano
[not found] ` <7vk5tx5333.fsf@assigned-by-dhcp.pobox.com>
2007-06-21 5:01 ` Shawn O. Pearce [this message]
2007-06-21 19:39 ` [PATCH] git-gui: use "blame -w -C -C" for "where did it come from, originally?" Linus Torvalds
2007-06-21 19:47 ` Linus Torvalds
2007-06-22 3:34 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070621050117.GF8477@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.