From: Ralf Baechle <ralf@linux-mips.org>
To: Daniel Laird <daniel.j.laird@nxp.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Philips(NXP)/STB810 changes
Date: Thu, 21 Jun 2007 15:27:21 +0100 [thread overview]
Message-ID: <20070621142721.GC21938@linux-mips.org> (raw)
In-Reply-To: <11232209.post@talk.nabble.com>
On Thu, Jun 21, 2007 at 05:37:25AM -0700, Daniel Laird wrote:
> Please find the new patch below - I hope it is following the correct rules
> now.
This is a good opportunity to advertise the checkpatch.pl script which is
part of the latest kernel once more. For example running it against your
patch results gives:
[ralf@denk linux-queue]$ scripts/checkpatch.pl /tmp/xxx
line over 80 characters
#107: FILE: arch/mips/philips/pnx8550/common/setup.c:117:
+ (PR4450_CMEM_SIZE_128MB << PR4450_CMEMB_SIZE) |
line over 80 characters
#112: FILE: arch/mips/philips/pnx8550/common/setup.c:122:
+ (PR4450_CMEM_SIZE_128MB << PR4450_CMEMB_SIZE) |
trailing whitespace
#141:
>> +++ kernel-new/arch/mips/philips/pnx8550/common/setup.c $
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
[ralf@denk linux-queue]$
next prev parent reply other threads:[~2007-06-21 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-21 9:02 [PATCH] Philips(NXP)/STB810 changes Daniel Laird
2007-06-21 11:57 ` Sergei Shtylyov
2007-06-21 12:37 ` Daniel Laird
2007-06-21 14:27 ` Ralf Baechle [this message]
2007-06-22 6:33 ` Daniel Laird
2007-06-22 6:41 ` Daniel Laird
2007-06-27 12:58 ` Ralf Baechle
-- strict thread matches above, loose matches on Subject: below --
2007-06-27 14:19 Daniel Laird
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070621142721.GC21938@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=daniel.j.laird@nxp.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.