From: Olaf Hering <olaf@aepfle.de>
To: Andi Kleen <ak@suse.de>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH for 2.6.22] [6/10] x86: Only make Macintosh drivers default on Macs
Date: Thu, 21 Jun 2007 19:52:00 +0200 [thread overview]
Message-ID: <20070621175200.GA22507@aepfle.de> (raw)
In-Reply-To: <20070621173628.GA21243@aepfle.de>
On Thu, Jun 21, Olaf Hering wrote:
> On Wed, Jun 20, Andi Kleen wrote:
> > It's already annoying that they appear on x86 now -- that's for the 3button
> > emulation needed on x86 macs -- but at least don't make them default.
> > +++ linux/drivers/macintosh/Kconfig
> > @@ -2,7 +2,7 @@
> > menuconfig MACINTOSH_DRIVERS
> > bool "Macintosh device drivers"
> > depends on PPC || MAC || X86
> > - default y
> > + default y if MAC
>
> This looks incorrect because my macdrivers were almost gone now when
> updating from 2.6.21 to 2.6.22.
> A better one may be something like this, to not lose everything on a G5:
This one works.
Without it, every previously enabled option will default to N during
make oldconfig.
With it, every previously enabled option remains the same because make
oldcconfig does not touch them.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
index 0852d33..dbe9626 100644
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
@@ -2,7 +2,7 @@
menuconfig MACINTOSH_DRIVERS
bool "Macintosh device drivers"
depends on PPC || MAC || X86
- default y if MAC
+ default y if (PPC_PMAC || MAC)
if MACINTOSH_DRIVERS
next prev parent reply other threads:[~2007-06-21 17:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 10:23 [PATCH for 2.6.22] [0/10] X86 late bug fixes for 2.6.22 Andi Kleen
2007-06-20 10:23 ` [PATCH for 2.6.22] [1/10] i386: bug in i386 MTRR initialization Andi Kleen
2007-06-20 21:16 ` Linus Torvalds
2007-06-20 10:23 ` [PATCH for 2.6.22] [2/10] x86_64: Fix readahead/sync_file_range/fadvise64 compat calls Andi Kleen
2007-06-20 10:23 ` [PATCH for 2.6.22] [3/10] x86_64: Fix eventd/timerfd syscalls Andi Kleen
2007-06-20 10:23 ` [PATCH for 2.6.22] [4/10] x86: Disable DAC on VIA bridges Andi Kleen
2007-06-20 10:23 ` [PATCH for 2.6.22] [5/10] x86_64: Quieten Atari keyboard warnings in Kconfig Andi Kleen
2007-06-20 12:31 ` Roman Zippel
2007-06-20 10:23 ` [PATCH for 2.6.22] [6/10] x86: Only make Macintosh drivers default on Macs Andi Kleen
2007-06-21 17:36 ` Olaf Hering
2007-06-21 17:52 ` Olaf Hering [this message]
2007-06-22 6:45 ` Andi Kleen
2007-06-21 17:58 ` Will Schmidt
2007-06-21 18:26 ` Linus Torvalds
2007-06-21 18:54 ` Olaf Hering
2007-06-21 21:09 ` Will Schmidt
2007-06-20 10:23 ` [PATCH for 2.6.22] [7/10] x86: Disable KPROBES with DEBUG_RODATA for now Andi Kleen
2007-06-20 10:23 ` [PATCH for 2.6.22] [8/10] x86: change_page_attr bandaids Andi Kleen
2007-06-20 10:23 ` [PATCH for 2.6.22] [9/10] i386: Disable alternative() patching after boot with DEBUG_RODATA Andi Kleen
2007-06-20 11:55 ` [patches] [PATCH for 2.6.22] [9/10] i386: Disable alternative()patching after boot with DEBUG_RO Jan Beulich
2007-06-20 12:27 ` Andi Kleen
2007-06-20 10:23 ` [PATCH for 2.6.22] [10/10] x86_64: fix link warning between for .text and .init.text Andi Kleen
2007-06-20 12:02 ` [patches] [PATCH for 2.6.22] [10/10] x86_64: fix link warningbetween " Jan Beulich
2007-06-20 12:30 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070621175200.GA22507@aepfle.de \
--to=olaf@aepfle.de \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.