From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1I26rj-0005Cc-Vr for mharc-grub-devel@gnu.org; Sat, 23 Jun 2007 10:45:32 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I26ri-0005C2-FQ for grub-devel@gnu.org; Sat, 23 Jun 2007 10:45:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I26rh-0005Ba-PR for grub-devel@gnu.org; Sat, 23 Jun 2007 10:45:29 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I26rh-0005BW-HJ for grub-devel@gnu.org; Sat, 23 Jun 2007 10:45:29 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I26rh-0000Om-41 for grub-devel@gnu.org; Sat, 23 Jun 2007 10:45:29 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1I26rP-0000fz-HR for grub-devel@gnu.org; Sat, 23 Jun 2007 16:45:26 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1I26sq-0001O5-5K for grub-devel@gnu.org; Sat, 23 Jun 2007 16:46:40 +0200 Date: Sat, 23 Jun 2007 16:46:40 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070623144640.GA32281@aragorn> References: <20070623115827.GA27818@aragorn> <87ejk2onps.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ejk2onps.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-Spam-Score: -1.4 (-) X-detected-kernel: Genre and OS details not recognized. Subject: Re: serial module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2007 14:45:30 -0000 On Sat, Jun 23, 2007 at 02:32:47PM +0200, Marco Gerards wrote: > > You forgot a changelog entry :-/ How about.. * conf/i386-pc.rmk: (pkgdata_MODULES): Add serial.mod. > > diff -ur grub2-1.95+20070621.old/conf/i386-pc.rmk grub2-1.95+20070621/conf/i386-pc.rmk > > --- grub2-1.95+20070621.old/conf/i386-pc.rmk 2007-06-11 08:26:18.000000000 +0200 > > +++ grub2-1.95+20070621/conf/i386-pc.rmk 2007-06-23 13:56:12.000000000 +0200 > > @@ -91,7 +91,7 @@ > > commands/terminal.c commands/ls.c commands/test.c \ > > commands/search.c commands/blocklist.c \ > > commands/i386/pc/halt.c commands/i386/pc/reboot.c \ > > - commands/i386/cpuid.c \ > > + commands/i386/cpuid.c term/i386/pc/serial.c \ > > Why do you add it to grub-emu? This is wrong because you can't access > the hardware from grub-emu. Oops. > The same is true for cpuid, I think. Are > you sure it works in grub-emu? Yes, cpuid should work everywhere as long as your cpu supports it. > Please test if it still builds, when > adding stuff. Sure (I even tested that it runs and sets up the serial console correctly). > > disk/loopback.c disk/raid.c disk/lvm.c \ > > fs/affs.c fs/ext2.c fs/fat.c fs/fshelp.c fs/hfs.c fs/iso9660.c \ > > fs/jfs.c fs/minix.c fs/sfs.c fs/ufs.c fs/xfs.c fs/hfsplus.c \ > > @@ -131,7 +131,7 @@ > > pkgdata_MODULES = _chain.mod _linux.mod linux.mod normal.mod \ > > _multiboot.mod chain.mod multiboot.mod reboot.mod halt.mod \ > > vbe.mod vbetest.mod vbeinfo.mod video.mod gfxterm.mod \ > > - videotest.mod play.mod bitmap.mod tga.mod cpuid.mod > > + videotest.mod play.mod bitmap.mod tga.mod cpuid.mod serial.mod > > Good catch, I also wonder why this wasn't added. Can you please apply > this change? Done. -- Robert Millan My spam trap is honeypot@aybabtu.com. Note: this address is only intended for spam harvesters. Writing to it will get you added to my black list.