From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 8C111DDE45 for ; Mon, 25 Jun 2007 15:53:17 +1000 (EST) Date: Mon, 25 Jun 2007 06:53:04 +0100 From: Christoph Hellwig To: Olof Johansson Subject: Re: [PATCH] pcmcia: ppc64 needs 32-bit ioaddr_t Message-ID: <20070625055304.GA1057@infradead.org> References: <20070625005439.GA31289@lixom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070625005439.GA31289@lixom.net> Cc: akpm@osdl.org, linuxppc-dev@ozlabs.org, linux-pcmcia@lists.infradead.org, paulus@samba.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Jun 24, 2007 at 07:54:39PM -0500, Olof Johansson wrote: > ppc64 really needs ioaddr_t to be 32-bit, since I/O addresses really are > MMIO addresses, and remapped at an offset that's well above 16 bits in > some cases. > > While the type is exported to userspace, there hasn't been any platforms > with PCMCIA on 64-bit powerpc until now, so changing it won't regress > any existing users. Drivers should be using kio_addr_t, please fix up the remaining drivers to do this instead of chaning the user-visible type. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755882AbXFYFxW (ORCPT ); Mon, 25 Jun 2007 01:53:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753483AbXFYFxN (ORCPT ); Mon, 25 Jun 2007 01:53:13 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:33723 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380AbXFYFxM (ORCPT ); Mon, 25 Jun 2007 01:53:12 -0400 Date: Mon, 25 Jun 2007 06:53:04 +0100 From: Christoph Hellwig To: Olof Johansson Cc: linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org, akpm@osdl.org, linuxppc-dev@ozlabs.org, paulus@samba.org Subject: Re: [PATCH] pcmcia: ppc64 needs 32-bit ioaddr_t Message-ID: <20070625055304.GA1057@infradead.org> Mail-Followup-To: Christoph Hellwig , Olof Johansson , linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org, akpm@osdl.org, linuxppc-dev@ozlabs.org, paulus@samba.org References: <20070625005439.GA31289@lixom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070625005439.GA31289@lixom.net> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 24, 2007 at 07:54:39PM -0500, Olof Johansson wrote: > ppc64 really needs ioaddr_t to be 32-bit, since I/O addresses really are > MMIO addresses, and remapped at an offset that's well above 16 bits in > some cases. > > While the type is exported to userspace, there hasn't been any platforms > with PCMCIA on 64-bit powerpc until now, so changing it won't regress > any existing users. Drivers should be using kio_addr_t, please fix up the remaining drivers to do this instead of chaning the user-visible type.