Re: [PATCH/RFC 10/11] Shared Policy: per cpuset shared file policy control

[Paul Jackson <pj@sgi.com>]

Lee wrote:
> +#ifdef CONFIG_NUMA

Hmmm ... our very first ifdef CONFIG_NUMA in kernel/cpuset.c,
and the second ifdef ever in that file.  (And I doubt that
the first ifdef, on CONFIG_MEMORY_HOTPLUG, is necessary.)

How about we just remove these ifdef CONFIG_NUMA's, and
let that per-cpuset 'shared_file_policy' always be present?
It just won't do a heck of a lot on non-NUMA systems.

No sense in breaking code that happens to access that file,
just because we're running on a system where it's useless.
It seems better to just simply, consistently, always have
that file present.

And I don't like ifdef's in kernel/cpuset.c.  If necessary,
put them in some header file, related to whatever piece of
code has to shrink down to nothingness when not configured.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>