Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 21 Jun 2007 18:48:30 +0530
"pradeep singh" <pradeep.rautela@gmail.com> wrote:

> diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c
> index 231ce43..006c634 100644
> --- a/drivers/net/chelsio/cxgb2.c
> +++ b/drivers/net/chelsio/cxgb2.c
> @@ -1022,6 +1022,11 @@ static int __devinit init_one(struct pci_dev *pdev,
>        mmio_start = pci_resource_start(pdev, 0);
>        mmio_len = pci_resource_len(pdev, 0);
>        bi = t1_get_board_info(ent->driver_data);
> +
> +       if (!bi) {
> +                CH_ERR("%s: Board info array index out of range\n",pci_name(pdev));
> +                goto out_disable_pdev;
> +        }
> 
>        for (i = 0; i < bi->port_number; ++i) {
>                struct net_device *netdev;

The chelsio driver is assuming that pci_device_id.driver_data has been
initialised to the board index, but I am unable to locate anywhere where
that initialisation actually happens.  Is this a bug?

(Who maintains this driver now?)