All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] ppc4xx: Remove sequoia/sequioa.h. Cleanup ppc440.h for PPC440EPX
Date: Mon, 25 Jun 2007 20:16:21 +0200	[thread overview]
Message-ID: <200706252016.21756.sr@denx.de> (raw)
In-Reply-To: <200706251748.19755.niklausgiger@gmx.ch>

Hi Niklaus,

On Monday 25 June 2007, Niklaus Giger wrote:
> The only lines which I exceed 80 characters are lines that my patch does
> not touch or removes them. Is it my duty to fix all lines which are too
> long in a source file? Or did I miss a line?

I'm not talking about too long coding lines, but the line wrap most likely 
caused by your mail client. For example the sequoia.h file (even if removed) 
has some line wraps which case that the patch can't be applied clean.

> Does the limit of 80 characters also apply to *.h-files? If yes, we have
> about 485 lines to fix in include/ppc*.h.

Normally the 80 characters line length also apply the the headers (all source 
code files). But you don't have to clean up existing code. Please just make 
sure that your mail client doesn't warp the lines upon sending.

Hint: Please send the mail first to yourself and try to apply the patch to 
your repository. If this works without any problems you can send it to the 
list.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2007-06-25 18:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-25 13:25 [U-Boot-Users] [PATCH] ppc4xx: Remove sequoia/sequioa.h. Cleanup ppc440.h for PPC440EPX Niklaus Giger
2007-06-25 15:05 ` Stefan Roese
2007-06-25 15:48   ` Niklaus Giger
2007-06-25 18:16     ` Stefan Roese [this message]
2007-06-27  8:52       ` Niklaus Giger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706252016.21756.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.