From: Andrew Morton <akpm@linux-foundation.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: linux-kernel@vger.kernel.org, "Antonino A. Daplas" <adaplas@pol.net>
Subject: Re: [PATCH] fix section mismatch in chipsfb
Date: Mon, 25 Jun 2007 22:07:52 -0700 [thread overview]
Message-ID: <20070625220752.4b4104f3.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070619221528.GA22413@aepfle.de>
On Wed, 20 Jun 2007 00:15:28 +0200 Olaf Hering <olaf@aepfle.de> wrote:
> Maybe this is the correct fix:
>
> WARNING: drivers/built-in.o(.text+0x8742a): Section mismatch: reference to .init.data:chipsfb_fix (between 'chipsfb_pci_init' and 'chipsfb_set_par')
> WARNING: drivers/built-in.o(.text+0x87432): Section mismatch: reference to .init.data:chipsfb_fix (between 'chipsfb_pci_init' and 'chipsfb_set_par')
> WARNING: drivers/built-in.o(.text+0x87442): Section mismatch: reference to .init.data:chipsfb_var (between 'chipsfb_pci_init' and 'chipsfb_set_par')
> WARNING: drivers/built-in.o(.text+0x8744a): Section mismatch: reference to .init.data:chipsfb_var (between 'chipsfb_pci_init' and 'chipsfb_set_par')
>
> init_chips is only called from chipsfb_pci_init
> chipsfb_fix and chipsfb_var are only referenced from init_chips
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> --- a/drivers/video/chipsfb.c
> +++ b/drivers/video/chipsfb.c
> @@ -292,7 +292,7 @@ static void __init chips_hw_init(void)
> write_fr(chips_init_fr[i].addr, chips_init_fr[i].data);
> }
>
> -static struct fb_fix_screeninfo chipsfb_fix __initdata = {
> +static struct fb_fix_screeninfo chipsfb_fix __devinitdata = {
> .id = "C&T 65550",
> .type = FB_TYPE_PACKED_PIXELS,
> .visual = FB_VISUAL_PSEUDOCOLOR,
> @@ -309,7 +309,7 @@ static struct fb_fix_screeninfo chipsfb_
> .smem_len = 0x100000, /* 1MB */
> };
>
> -static struct fb_var_screeninfo chipsfb_var __initdata = {
> +static struct fb_var_screeninfo chipsfb_var __devinitdata = {
> .xres = 800,
> .yres = 600,
> .xres_virtual = 800,
> @@ -330,7 +330,7 @@ static struct fb_var_screeninfo chipsfb_
> .vsync_len = 8,
> };
>
> -static void __init init_chips(struct fb_info *p, unsigned long addr)
> +static void __devinit init_chips(struct fb_info *p, unsigned long addr)
> {
> memset(p->screen_base, 0, 0x100000);
>
It looks like the correct fix to me.
prev parent reply other threads:[~2007-06-26 5:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 22:15 [PATCH] fix section mismatch in chipsfb Olaf Hering
2007-06-26 5:07 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070625220752.4b4104f3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@pol.net \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.