From: Andrew Morton <akpm@linux-foundation.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: a.zummo@towertech.it, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com, ab@mycable.de, mgreer@mvista.com,
khali@linux-fr.org, david-b@pacbell.net
Subject: Re: [PATCH 1/2] rtc: add rtc-m41t80 driver
Date: Mon, 25 Jun 2007 22:21:42 -0700 [thread overview]
Message-ID: <20070625222142.e9215829.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070626.141536.126143027.nemoto@toshiba-tops.co.jp>
On Tue, 26 Jun 2007 14:15:36 +0900 (JST) Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> On Mon, 25 Jun 2007 21:46:20 -0700, Andrew Morton <akpm@linux-foundation.org> wrote:
> > > + const static struct m41t80_chip_info *chip;
> >
> > It's a bit weird that `chip' has static storage class here. Was that
> > deliberate?
>
> Oh the variable should not be static!
> I will send updated patch.
I'll fix it up.
> BTW, I reveived following mails:
>
> Subject: - rtc-watchdog-support-for-rtc-m41t80-driver-take-2.patch removed from -mm tree
> Subject: - rtc-add-rtc-m41t80-driver-take-2.patch removed from -mm tree
> Subject: + rtc-add-rtc-m41t80-driver.patch added to -mm tree
> Subject: + rtc-watchdog-support-for-rtc-m41t80-driver.patch added to -mm tree
>
> Are you going back to "take 1" patches? Why?
Stupidity, apparently. Will restore the take2 patches.
next prev parent reply other threads:[~2007-06-26 5:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 17:09 [PATCH 1/2] rtc: add rtc-m41t80 driver Atsushi Nemoto
2007-06-26 4:46 ` Andrew Morton
2007-06-26 5:15 ` Atsushi Nemoto
2007-06-26 5:21 ` Andrew Morton [this message]
2007-06-29 3:04 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070625222142.e9215829.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=ab@mycable.de \
--cc=anemo@mba.ocn.ne.jp \
--cc=david-b@pacbell.net \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@mvista.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.