From: David Chinner <dgc@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] simplify vnode tracing calls
Date: Tue, 26 Jun 2007 09:54:36 +1000 [thread overview]
Message-ID: <20070625235436.GD31489@sgi.com> (raw)
In-Reply-To: <467FCA62.8080800@sandeen.net>
On Mon, Jun 25, 2007 at 09:00:02AM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > On Mon, Jun 25, 2007 at 12:19:15AM -0500, Eric Sandeen wrote:
> >> Don't think I've sent this one yet... :)
> >
> > Any chance we can keep the name lower-cases despite the simplified
> > prototype?
>
> Yeah, it is a bit of a mishmash this way isn't it. SGI guys, do you
> have a preference? Christoph, how would you do it, vn_trace_enter(vp)
> macro calling __vn_trace_enter() function?
Yeah, keep the lower case names if possible. I can't think of a simpler
way of doing it, and it's not terribly ugly. I'm open to better
solutions, though.....
> > Also it might make sense to merge the previous patch into
> > this one.
>
> *shrug* either way.
Keep 'em separate - that way I don't have to go and review this
first one again ;)
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-06-25 23:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 5:19 [PATCH] simplify vnode tracing calls Eric Sandeen
2007-06-25 6:20 ` Christoph Hellwig
2007-06-25 14:00 ` Eric Sandeen
2007-06-25 23:54 ` David Chinner [this message]
2007-06-26 17:00 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070625235436.GD31489@sgi.com \
--to=dgc@sgi.com \
--cc=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.