From: Rob Landley <rob@landley.net>
To: linux-kernel@vger.kernel.org
Cc: David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH] Fix headers_install for x86-64 (now with less whitespace damage!)
Date: Tue, 26 Jun 2007 09:12:36 -0400 [thread overview]
Message-ID: <200706260912.37441.rob@landley.net> (raw)
Signed-off-by: Rob Landley <rob@landley.net>
A bug in headers_install for ARCH=x86_64 yields an asm/ directory full of
files all of which are using the same #ifdef guard, "__ASM_STUB_" with no
postfix. So the second and later asm files #included in the same C file
(often through standard headers like ioctl.h) yields no symbols.
--
There's a missing semicolon after the assignment to FNAME (so the assignment
of STUBDEF on the next line doesn't see the value), and it helps to export
variables before calling a subshell.
Second try, telling Kmail not to wordwrap inappropriately. (I am up waaaay
too early to get ready for OLS...)
--- linux-2.6/scripts/Makefile.headersinst 2007-06-15 02:45:07.000000000 -0400
+++ linux/scripts/Makefile.headersinst 2007-06-26 08:54:13.000000000 -0400
@@ -108,8 +108,8 @@
quiet_cmd_gen = GEN $(patsubst $(INSTALL_HDR_PATH)/%,%,$@)
cmd_gen = \
-FNAME=$(patsubst $(INSTALL_HDR_PATH)/$(_dst)/%,%,$@) \
-STUBDEF=__ASM_STUB_`echo $$FNAME | tr a-z.- A-Z__`; \
+export FNAME=$(patsubst $(INSTALL_HDR_PATH)/$(_dst)/%,%,$@); \
+export STUBDEF=__ASM_STUB_`echo $$FNAME | tr a-z.- A-Z__`; \
(echo "/* File autogenerated by 'make headers_install' */" ; \
echo "\#ifndef $$STUBDEF" ; \
echo "\#define $$STUBDEF" ; \
--
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
next reply other threads:[~2007-06-26 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 13:12 Rob Landley [this message]
2007-06-26 14:03 ` [PATCH] Fix headers_install for x86-64 (now with less whitespace damage!) David Woodhouse
2007-06-26 14:48 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706260912.37441.rob@landley.net \
--to=rob@landley.net \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.