Re: [lm-sensors] Hacking on libsensors

[Jean Delvare <khali@linux-fr.org>]

Hi Hans,

On Wed, 27 Jun 2007 17:19:56 +0200, Hans de Goede wrote:
> Jean Delvare wrote:
> > Hi all,
> > 
> > My employer, Novell, has organized a "hack week". This is one week where
> > every employee is free to hack on whatever he/she wants [1].
> > Unsurprisingly I decided I would spend that time on libsensors. I
> > posted the idea here:
> > http://idea.opensuse.org/content/ideas/generic-sensors-library
> 
> It sounds like an excellent plan to start working on the 3.0 branch! Let me 
> know if you need any help, and/or when you want me to test this on the machines 
> I have access too.

I'll let you know. However, I fear that I've been spending too much
time on the cleanup steps. 3 days have passed already, only 2 left, and
I still didn't have a look at the libsensors interface. Not to say that
the work I've done wasn't needed, it certainly was, but I don't think
there will be much to test at the end of this week. I'll have to find
more time to keep working on it in the next few weeks.

> Some time ago we had a discussion about amongst other things some bad 
> assumptions in the generic voltage printing code. I promised to fix this, but 
> its still on my todo, I will happily fix this once things stabilize (I would 
> like to avoid svn commit conflicts), if you feel inclined to fix it yourself 
> thats fine too, here is the important part of our previous conversation on this:
> 
>  > Also print_generic_chip_in(), has some dangerous and unneeded assumptions, for
>  > example:
>  > -it assumes that if there is a inX_max that there will also always be a inX_min
>  > -it assumes that if there is no inX_max there will also be no alarms
>  >
> Somewhat less "unneeded" assumption
>  > -it doesn't check for inX_max_alarm without an inX_min_alarm and visa versa, I
>  >   admit this would be a driver bug, as then the driver should have just a
>  >   inX_alarm, but still we might want to concider this.

Please commit your changes as soon as possible. Don't worry about
conflicts, I won't touch this part of the code before you've committed
your own changes.

Thanks,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors