All of lore.kernel.org
 help / color / mirror / Atom feed
From: mgrac@sourceware.org <mgrac@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/rgmanager ChangeLog src/daemons/rg_state.c
Date: 28 Jun 2007 11:54:51 -0000	[thread overview]
Message-ID: <20070628115451.23270.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL4
Changes by:	mgrac at sourceware.org	2007-06-28 11:54:50

Modified files:
	rgmanager      : ChangeLog 
	rgmanager/src/daemons: rg_state.c 

Log message:
	Fix #236431
	Message in log file: Taking over service serv from down member (null)
	shows correct member (if possible).

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/ChangeLog.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.5.2.26&r2=1.5.2.27
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/rgmanager/src/daemons/rg_state.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.4.2.20&r2=1.4.2.21

--- cluster/rgmanager/ChangeLog	2007/06/22 08:40:20	1.5.2.26
+++ cluster/rgmanager/ChangeLog	2007/06/28 11:54:50	1.5.2.27
@@ -1,3 +1,7 @@
+2007-06-28 Marek Grac <mgrac@redhat.com>
+	* src/daemons/rg_state.c: Fix #236431. Message: Taking over service
+	serv from down member (null) shows correct member (if possible).
+
 2007-06-22 Marek Grac <mgrac@redhat.com>
 	* src/daemons/reslist.c: Apply patch from Lon (same as in RHEL5) to
 	fix #245171 attr inheritance should try all direct ancestors.
--- cluster/rgmanager/src/daemons/rg_state.c	2007/05/03 15:02:47	1.4.2.20
+++ cluster/rgmanager/src/daemons/rg_state.c	2007/06/28 11:54:50	1.4.2.21
@@ -490,6 +490,9 @@
 {
 	cluster_member_list_t *membership = member_list();
 	int ret = 0;
+	int fd;
+	char *nodename = NULL;
+	char query[255];
 	
 	switch(svcStatus->rs_state) {
 	case RG_STATE_FAILED:
@@ -549,10 +552,19 @@
 		/*
 		 * Service is running but owner is down -> FAILOVER
 		 */
+		fd = ccs_connect();
+		if (fd > 0) {
+			snprintf(query,
+				sizeof(query),
+				"/cluster/clusternodes/clusternode[@nodeid=\"%d\"]/@name",
+				svcStatus->rs_owner);
+			ccs_get(fd, query, &nodename);
+			ccs_disconnect(fd);
+		}
+
 		clulog(LOG_NOTICE,
 		       "Taking over service %s from down member %s\n",
-		       svcName, memb_id_to_name(membership,
-						svcStatus->rs_owner));
+		       svcName, nodename);
 		ret = 1;
 		break;
 



             reply	other threads:[~2007-06-28 11:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-28 11:54 mgrac [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-25 18:09 [Cluster-devel] cluster/rgmanager ChangeLog src/daemons/rg_state.c lhh
2007-06-14 14:53 lhh
2006-09-27 12:26 lhh
2006-09-27 12:22 lhh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070628115451.23270.qmail@sourceware.org \
    --to=mgrac@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.