From: David Chinner <dgc@sgi.com>
To: Ruben Porras <ruben.porras@linworks.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] Implement ioctl to mark AGs as "don't use/use"
Date: Fri, 29 Jun 2007 10:54:17 +1000 [thread overview]
Message-ID: <20070629005417.GF31489@sgi.com> (raw)
In-Reply-To: <46838CAE.9030808@linworks.de>
On Thu, Jun 28, 2007 at 12:25:50PM +0200, Ruben Porras wrote:
> Ok, thank you for the explanation, I think that now I got it right.
> Attached is a new patch.
Only one minor nit:
> @@ -558,6 +559,17 @@
> ASSERT(args->minlen <= args->maxlen);
> ASSERT(args->mod < args->prod);
> ASSERT(args->alignment > 0);
> +
> + /*
> + * Return an error if the a.g. should not be allocated.
> + * This happens normally during a shrink operation.
> + */
> + pag = (args->pag);
Kill the () here.
Otherwise, looks good.
OOC, do you have any test code for this? xfs_io would be the tool to
teach this ioctl to....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-06-29 0:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-27 10:15 [PATCH] Implement ioctl to mark AGs as "don't use/use" Ruben Porras
2007-06-28 4:50 ` David Chinner
2007-06-28 10:25 ` Ruben Porras
2007-06-29 0:35 ` David Chinner
2007-06-29 0:54 ` David Chinner [this message]
2007-09-03 9:20 ` Ruben Porras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070629005417.GF31489@sgi.com \
--to=dgc@sgi.com \
--cc=ruben.porras@linworks.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.