Re: feature request - prevent user stupidity (eg mine)

["Daniel P. Berrange" <berrange@redhat.com>]

On Fri, Jun 29, 2007 at 01:05:18AM +0100, Mark Williamson wrote:
> > > Given that there is almost no way you would ever want to publish the
> > > same block device to the same virtual domain more than once, would
> >
> > there
> >
> > > be any value in flagging that as an error when you try and start the
> > > domain?
> >
> > I'm surprised that the existing block device safety checks don't pick up
> > on this, but I guess they're run before the guest is started rather than
> > before each virtual disk is attached.
> 
> Looks like the hotplug scripts do contain the checking logic, and it does 
> check each device at a time, but it explicitly ignores if the same VM already 
> has access to a device.  Maybe checking for duplicate exports here would be 
> too racey, since I guess the hotplug scripts are not run in any particular 
> order...

Well duplicate devices in the same VM could be fairly easily checked by XenD
itself before it gets anywhere near creating the VM or doing device hotplug.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|