All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Thomas Sattler <tsattler@gmx.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>, Daniel Mack <daniel@qanu.de>,
	Holger Waechtler <holger@qanu.de>,
	Dmitry Torokhov <dtor@insightbb.com>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	Mariusz Kozlowski <m.kozlowski@tuxland.pl>,
	v4l-dvb-maintainer@linuxtv.org
Subject: Re: 2.6.22-rc6 spurious hangs
Date: Fri, 29 Jun 2007 16:10:59 +0200	[thread overview]
Message-ID: <20070629141059.GA8995@elte.hu> (raw)
In-Reply-To: <20070629135848.GA332@tv-sign.ru>


* Oleg Nesterov <oleg@tv-sign.ru> wrote:

> > > ->disconnect_pending is used without any locks/barriers, perhaps 
> > > this is the reason.
> 
> I misread cinergyt2_release, it checks !->disconnect_pending, so it is 
> very clear why cinergyt2_query_rc() tries to take the mutex.
> 
> > > I'll try to look further tomorrow. In any case, cinergyT2 should not 
> > > use flush_scheduled_work() at all.
> > 
> > would the hack below be worth trying, to see whether there are any 
> > further problems?
[...]
> I don't think we can just kill flush_scheduled_work(). We can use 
> cancel_rearming_delayed_work() instead of 
> cancel_delayed_work()+flush_scheduled_work()
> 
> Still we can't do this under cinergyt2->sem, because cinergyt2_query() 
> takes it too. This all looks very wrong to me, I hope maintaners can 
> explain.

i've Cc:-ed the maintainers.

	Ingo

  reply	other threads:[~2007-06-29 14:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-28 14:00 2.6.22-rc6 spurious hangs Thomas Sattler
2007-06-28 14:47 ` Oleg Nesterov
2007-06-28 14:58   ` Thomas Sattler
2007-06-28 15:00     ` Ingo Molnar
     [not found]     ` <20070628150826.GA487@tv-sign.ru>
2007-06-28 17:35       ` Thomas Sattler
2007-06-28 17:49         ` Thomas Sattler
2007-06-28 18:10           ` Oleg Nesterov
2007-06-28 21:31             ` Thomas Sattler
2007-06-29  7:13             ` Thomas Sattler
2007-06-29 13:09               ` Oleg Nesterov
2007-06-29 13:16                 ` Ingo Molnar
2007-06-29 13:58                   ` Oleg Nesterov
2007-06-29 14:10                     ` Ingo Molnar [this message]
2007-06-29 16:59                       ` Dmitry Torokhov
2007-06-29 17:23                         ` Oleg Nesterov
2007-06-29 21:21                     ` Mauro Carvalho Chehab
2007-06-29 21:34                       ` Markus Rechberger
2007-06-30 14:19                         ` Oleg Nesterov
2007-07-01 18:54                           ` Thomas Sattler
2007-07-01 19:47                             ` Oleg Nesterov
2007-07-02  4:48                               ` Thomas Sattler
2007-06-29 11:15 ` Tomi Orava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070629141059.GA8995@elte.hu \
    --to=mingo@elte.hu \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=daniel@qanu.de \
    --cc=dtor@insightbb.com \
    --cc=holger@qanu.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.kozlowski@tuxland.pl \
    --cc=mchehab@infradead.org \
    --cc=oleg@tv-sign.ru \
    --cc=tsattler@gmx.de \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.