From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I4Pxo-0001II-Sl for qemu-devel@nongnu.org; Fri, 29 Jun 2007 19:33:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I4Pxm-0001I6-HY for qemu-devel@nongnu.org; Fri, 29 Jun 2007 19:33:19 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I4Pxm-0001I3-CD for qemu-devel@nongnu.org; Fri, 29 Jun 2007 19:33:18 -0400 Received: from phoenix.bawue.net ([193.7.176.60] helo=mail.bawue.net) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I4Pxm-00082w-1P for qemu-devel@nongnu.org; Fri, 29 Jun 2007 19:33:18 -0400 Date: Sat, 30 Jun 2007 00:27:09 +0100 Subject: Re: [Qemu-devel] patch vl.c, segfault with "qemu -h" Message-ID: <20070629232709.GA644@networkno.de> References: <200706291848.l5TImqXo021236@kyklops.ohsu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200706291848.l5TImqXo021236@kyklops.ohsu.edu> From: Thiemo Seufer Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marion Hakanson Cc: qemu-devel@nongnu.org Marion Hakanson wrote: > When you run "qemu -h", help() is called with optarg==NULL, which > causes a segfault on my system (Solaris-10U3_x86, 64-bit kernel, > but qemu compiled as 32-bit app, gcc-3.4.5 from blastwave.org). > It's a side-effect of the -r1.315 patch which fixed related segfaults. > > The following patch fixes the "-h" segfault, and also appears to yield > the exit value intended by previous folks. Thanks, I committed a fix which I hope is better. Thiemo