From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [PATCH] spi_mpc83xx.c, support QE enabled 83xx CPU's like mpc832x Date: Sat, 30 Jun 2007 08:11:56 -0700 Message-ID: <200706300811.56870.david-b@pacbell.net> References: <1183213370.20673.100.camel@gentoo-jocke.transmode.se> <1183215355.20673.106.camel@gentoo-jocke.transmode.se> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org Return-path: In-Reply-To: <1183215355.20673.106.camel-/EMGr9iCeazgSi9v3i4K4Pmbkio/vSLMs0AfqQuZ5sE@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Saturday 30 June 2007, Joakim Tjernlund wrote: > @@ -197,12 +203,22 @@ int mpc83xx_spi_setup_transfer(struct spi_device *spi, struct spi_transfer *t) > || ((bits_per_word > 16) && (bits_per_word != 32))) > return -EINVAL; > > + mpc83xx_spi->rx_shift = 0; > + mpc83xx_spi->tx_shift = 0; > if (bits_per_word <= 8) { > mpc83xx_spi->get_rx = mpc83xx_spi_rx_buf_u8; > mpc83xx_spi->get_tx = mpc83xx_spi_tx_buf_u8; > + if (mpc83xx_spi->qe_mode) { > + mpc83xx_spi->rx_shift = 16; This shouldn't be "8" or "24"? > + mpc83xx_spi->tx_shift = 24; > + } ... I got the update with the missing header file. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/