All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: "Török Edvin" <edwintorok@gmail.com>
Cc: zambrano@broadcom.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, power@bughost.org
Subject: Re: [PATCH] b44: power down PHY when interface down
Date: Sat, 30 Jun 2007 23:53:25 +0200	[thread overview]
Message-ID: <200706302353.25426.mb@bu3sch.de> (raw)
In-Reply-To: <4354d3270706300447ladcda4by987b1f87963112f9@mail.gmail.com>

On Saturday 30 June 2007 13:47:35 Török Edvin wrote:
> When the interface is down (or driver removed), the BroadCom 44xx card remains
> powered on, and both its MAC and PHY is using up power.
> This patch makes the driver issue a MAC_CTRL_PHY_PDOWN when the interface
> is halted, and does a partial chip reset turns off the activity LEDs too.
> 
> Applies to 2.6.22-rc6, or current git head.
> 
> Tested on a Broadcom BCM4401-B0 card, it saves ~0.5W (measured using powertop).

Hm, I was going to measure the real power advantage with a
PCI-extender card. But my B44B0 card doesn't seem to work in
that extender card. It works perfectly fine sticked directly into
the motherboard, though, and other cards like a BCM4318 work in
the extender, too.
Not sure what this is.
The extender has an application note about nonworking cards in the
extender and a too big resistor on the board IDSEL pin being the
cause of this.
Maybe I can try with another machine tomorrow.

-- 
Greetings Michael.

  parent reply	other threads:[~2007-06-30 21:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-30 11:47 [PATCH] b44: power down PHY when interface down Török Edvin
2007-06-30 12:05 ` Matthew Garrett
2007-06-30 14:44   ` Arjan van de Ven
2007-06-30 15:19     ` Matthew Garrett
2007-06-30 15:25       ` Lennert Buytenhek
2007-07-01 13:02       ` Török Edvin
2007-06-30 16:42     ` PM policy, hotplug, power saving (was Re: [PATCH] b44: power down PHY when interface down) Jeff Garzik
2007-06-30 18:10       ` Stephen Hemminger
2007-06-30 18:31       ` PM policy, hotplug, power saving and WoL Henrique de Moraes Holschuh
2007-07-01  4:51       ` PM policy, hotplug, power saving (was Re: [PATCH] b44: power down PHY when interface down) Kyle Moffett
     [not found] ` <4354d3270706300447ladcda4by987b1f87963112f9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-06-30 12:13   ` [PATCH] b44: power down PHY when interface down Stephen Hemminger
2007-07-01 12:49     ` Török Edvin
2007-07-01 12:55       ` Michael Buesch
2007-06-30 21:53 ` Michael Buesch [this message]
2007-06-30 22:03   ` Lennert Buytenhek
2007-06-30 22:24     ` Michael Buesch
2007-06-30 23:17       ` Lennert Buytenhek
2007-07-01 10:23         ` Michael Buesch
2007-07-01 15:00           ` Lennert Buytenhek
2007-07-01 15:29             ` Michael Buesch
2007-07-01 20:20             ` Michael Buesch
  -- strict thread matches above, loose matches on Subject: below --
2007-07-01 13:25 Török Edvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706302353.25426.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=edwintorok@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=power@bughost.org \
    --cc=zambrano@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.