From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu exec.c monitor.c
Date: Sun, 1 Jul 2007 19:26:08 +0100 [thread overview]
Message-ID: <200707011926.09003.paul@codesourcery.com> (raw)
In-Reply-To: <4687E465.9010505@mail.berlios.de>
On Sunday 01 July 2007, Stefan Weil wrote:
> ANSI / POSIX do not define "wa" as mode string for fopen.
> I have no idea how many implementations of libc
> will fail with this mode which was introduced by
> the latest version of exec.c.
>
> The standard mode for append is just "a".
You are correct. I've fixed this.
> Even better (because it is faster and creates smaller
> log files for Windows) is "ab" for append and "wb"
> otherwise.
We're writing human-readable text, so opening in binary mode is IMHO fairly
dubious. If you really want fast logs/traces there are better ways to speed
it up.
Paul
prev parent reply other threads:[~2007-07-01 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 13:53 [Qemu-devel] qemu exec.c monitor.c Paul Brook
2007-07-01 17:29 ` Stefan Weil
2007-07-01 18:26 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707011926.09003.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.