Re: [Patch] Fix keymap support for PVFB.

["Daniel P. Berrange" <berrange@redhat.com>]

On Mon, Jul 02, 2007 at 07:51:36PM +0900, Kasai Takanori wrote:
> However, I think that it should do this with xenkbd who is originally the 
> driver on the FrontEnd side.
> It will be problem if the HVM domain is working on PVFB in the future.

I honestly can't see HVM using the PVFB at any time in the forseeable future
unless PVFB is further developed to not suck. ie being able to change the 
resolution / bpp would be a start for PVFB - something HVM can already do
trivially.

> For HVM domain, The keycode that the keyboard driver on guest OS received 
> from
> qemu-dm is converted.
> It will convert further in the HVM domain when converting it with PVFB
> beforehand, and a correct key cannot be input.
> 
> This patch transplanted the conversion processing of the keyboard driver on 
> the GuestOS side to xenkbd.

This change looks very much like it breaks backwards compatability, doesn't
it ?

eg If you use an old Dom0 daemon with new kernel you'll not get any keymap 
conversion done. If you use a new Dom0 daemon with old kernel, you'll get 
keymap conversion done twice. 

I don't see any point in doing this change since it makes no difference to
the functionality of paravirt guests & there's no compelling need for PVFB
in the HVM guests.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|