All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: git@vger.kernel.org
Subject: being nice to patch(1)
Date: Mon, 2 Jul 2007 12:54:50 -0700	[thread overview]
Message-ID: <20070702125450.28228edd.akpm@linux-foundation.org> (raw)


James's current git-scsi-misc has this commit in it:


commit a16efc1cbf0a9e5ea9f99ae98fb774b60d05c35b
Author: Kars de Jong <jongk@linux-m68k.org>
Date:   Sun Jun 17 14:47:08 2007 +0200

[SCSI] 53c700: Amiga 4000T NCR53c710 SCSI
    
    New driver for the Amiga 4000T built-in NCR53c710 SCSI controller, using the
    53c700 SCSI core.
    
    Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>


When one pulls that diff out of git with `git-show' or whatever, it doesn't
work - patch(1) has a heart attack over the "53c700":


|commit f98754960a9b25057ad5f249f877b3d6fab889ce
|Author: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
|Date:   Mon May 14 20:25:31 2007 +0900
|
|    [SCSI] hptiop: convert to use the data buffer accessors
|    
|    - remove the unnecessary map_single path.
|    
|    - convert to use the new accessors for the sg lists and the
|    parameters.
|    
|    Jens Axboe <jens.axboe@oracle.com> did the for_each_sg cleanup.
|    
|    Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
|    Acked-by: HighPoint Linux Team <linux@highpoint-tech.com>
|    Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
|
|commit a16efc1cbf0a9e5ea9f99ae98fb774b60d05c35b
|Author: Kars de Jong <jongk@linux-m68k.org>
|Date:   Sun Jun 17 14:47:08 2007 +0200
|
|    [SCSI] 53c700: Amiga 4000T NCR53c710 SCSI
|    
|    New driver for the Amiga 4000T built-in NCR53c710 SCSI controller, using the
--------------------------
File to patch: 




This I assume is because ^[ ]*<number>c<number> is a magic marker for
contextual diffs.

So...  if someone is feeling really, really, really bored one day, it would
be nice to teach git to somehow escape such patch-magic-patterns in the
changelog when emitting plain old patches.

             reply	other threads:[~2007-07-02 19:55 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-02 19:54 Andrew Morton [this message]
2007-07-02 21:16 ` being nice to patch(1) Linus Torvalds
2007-07-02 21:25   ` Andrew Morton
2007-07-02 21:40     ` Linus Torvalds
2007-07-02 21:56       ` Andrew Morton
2007-07-03  0:28         ` Linus Torvalds
2007-07-03  4:00           ` Junio C Hamano
2007-07-03  4:14             ` Linus Torvalds
2007-07-03 12:04               ` Johannes Schindelin
2007-07-03 12:21                 ` Paolo Ciarrocchi
2007-07-03 12:35                   ` Johannes Schindelin
2007-07-03 18:39                   ` Theodore Tso
2007-07-03 19:48                     ` Linus Torvalds
2007-07-03 20:55                       ` Paul Eggert
2007-07-03 21:30                         ` Linus Torvalds
2007-07-03 21:35                           ` Linus Torvalds
2007-07-03 13:22                 ` David Kastrup
2007-07-03 13:39                   ` Johannes Schindelin
2007-07-03 13:54                     ` David Kastrup
2007-07-03 15:01                       ` [PATCH] diff --no-index: fix --name-status with added files Johannes Schindelin
2007-07-03 15:01                       ` being nice to patch(1) Johannes Schindelin
2007-07-03 15:08                         ` David Kastrup
2007-07-06 12:38                 ` David Kastrup
2007-07-06 15:22                   ` git-diff memory/speed/disk impacts (was: being nice to patch(1)) David Kastrup
2007-07-06 18:08                   ` being nice to patch(1) Linus Torvalds
2007-07-03 13:34           ` [Quilt-dev] " Andreas Gruenbacher
2007-07-03 15:49             ` Andrew Morton
2007-07-03 16:03               ` Linus Torvalds
2007-07-03 16:03               ` Andreas Gruenbacher
2007-07-03 16:15                 ` Andrew Morton
2007-07-03 21:03                 ` Andrew Morton
2007-07-03 21:03             ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070702125450.28228edd.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.