All of lore.kernel.org
 help / color / mirror / Atom feed
From: tsbogend@alpha.franken.de (Thomas Bogendoerfer)
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH UPDATE #2] Extract chip specific code out of lasi_82596.c
Date: Mon, 2 Jul 2007 15:41:05 +0200	[thread overview]
Message-ID: <20070702134105.GA7403@alpha.franken.de> (raw)
In-Reply-To: <4688F2D8.6020308@pobox.com>

On Mon, Jul 02, 2007 at 08:43:04AM -0400, Jeff Garzik wrote:
> applied both patches.
> 
> Please provide an update that does at Andrew requested -- rather than 
> #include'ing lib82596.c, you should update the Makefile for relevant 
> drivers to look like

I got the impression that Andrew is fine with that approach after my
explanation. I would need additional header files for all the
different swap macros/dma stuff, and that isn't nice either, isn't it ? 

There are other drivers doing the same as I do, which didn't get any
objections. Is it me you have a prolem with ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                                [ RFC1925, 2.3 ]

  reply	other threads:[~2007-07-02 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-27 22:46 [PATCH UPDATE #2] Extract chip specific code out of lasi_82596.c Thomas Bogendoerfer
2007-07-02 12:43 ` Jeff Garzik
2007-07-02 13:41   ` Thomas Bogendoerfer [this message]
2007-07-02 13:58     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070702134105.GA7403@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=akpm@linux-foundation.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.