All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] Getting rid of LM_DATE
Date: Tue, 03 Jul 2007 12:05:14 +0000	[thread overview]
Message-ID: <20070703140514.1ec402ae@hyperion.delvare> (raw)

Hi all, hi Phil,

For lm-sensors 3.0.0, I think we could get rid of LM_DATE. It's only
used in libsensors:

lib/data.c:const char *libsensors_date = LM_DATE;

And this symbol is not even advertised, so it is quite unlikely that
anyone is using it. Even we don't use it. I think that this string is
redundant with LM_VERSION anyway, so it's not very useful. So I propose
to get rid of LM_DATE and libsensors_date. Any objection?

LM_VERSION is also only used in libsensors:

lib/data.c:const char *libsensors_version = LM_VERSION;

It is also not advertised, still we use it in sensors:

prog/sensors/main.c:extern const char *libsensors_version;
prog/sensors/main.c:  printf("%s version %s with libsensors version %s\n", PROGRAM, VERSION, libsensors_version);

This needs to be cleaned up (I'll do.)

If we get rid of LM_DATE, then I also propose to get rid of the
"version" target in the Makefile. Changing the version string directly
in version.h seems rather easier. Phil, would that change be OK with
you?

Thanks,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

             reply	other threads:[~2007-07-03 12:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-03 12:05 Jean Delvare [this message]
2007-07-10 20:28 ` [lm-sensors] Getting rid of LM_DATE Jean Delvare
2007-07-19 17:02 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070703140514.1ec402ae@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.