All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-acpi@vger.kernel.org, netdev@vger.kernel.org, hadi@cyberus.ca
Subject: Re: [PATCH] ACPI: export acpi events via generic netlink
Date: Tue, 3 Jul 2007 15:45:16 -0400	[thread overview]
Message-ID: <200707031545.16787.lenb@kernel.org> (raw)
In-Reply-To: <1182224403.5411.84.camel@localhost.localdomain>

Thanks for including the demo program, Rui, it works for me (tm).

Applied -- with the incremental patch below, which I think
is correct because the only caller is bus.c, which is part of
the base kernel, not a module.  Modules will call
acpi_bus_generate_event(), not acpi_bus_generate_genetlink_event()
directly.

thanks,
-Len

commit b563d6f30d937510e02541930b1558d0f5759413
Author: Len Brown <len.brown@intel.com>
Date:   Tue Jul 3 15:32:23 2007 -0400

    ACPI: netlink: remove unnecessary EXPORT_SYMBOL
    
    Signed-off-by: Len Brown <len.brown@intel.com>

diff --git a/drivers/acpi/event.c b/drivers/acpi/event.c
index 98627b0..de4def9 100644
--- a/drivers/acpi/event.c
+++ b/drivers/acpi/event.c
@@ -221,7 +221,6 @@ int acpi_bus_generate_genetlink_event(struct acpi_device *device,
 				  "Failed to send a Genetlink message!\n"));
 	return 0;
 }
-EXPORT_SYMBOL(acpi_bus_generate_genetlink_event);
 
 static int acpi_event_genetlink_init(void)
 {
@@ -245,7 +244,6 @@ int acpi_bus_generate_genetlink_event(struct acpi_device *device, u8 type,
 {
 	return 0;
 }
-EXPORT_SYMBOL(acpi_bus_generate_genetlink_event);
 
 static int acpi_event_genetlink_init(void)
 {

  parent reply	other threads:[~2007-07-03 19:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-19  3:40 [PATCH] ACPI: export acpi events via generic netlink Zhang Rui
2007-07-03 17:18 ` Johannes Berg
2007-07-03 19:45 ` Len Brown [this message]
2007-07-04 12:01   ` Johannes Berg
2007-07-05  8:24     ` Zhang Rui
2007-07-05  8:35       ` Johannes Berg
2007-07-05  8:54         ` Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707031545.16787.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=hadi@cyberus.ca \
    --cc=linux-acpi@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.