From: "J. Bruce Fields" <bfields@fieldses.org>
To: Frank van Maarseveen <frankvm@frankvm.com>
Cc: Linux NFS mailing list <nfs@lists.sourceforge.net>
Subject: Re: [PATCH] lockd: unlock when client rejects GRANTED_MSG
Date: Tue, 3 Jul 2007 18:30:33 -0400 [thread overview]
Message-ID: <20070703223033.GG14074@fieldses.org> (raw)
In-Reply-To: <20070703222419.GD16497@janus>
On Wed, Jul 04, 2007 at 12:24:19AM +0200, Frank van Maarseveen wrote:
> I think your patch is addressing something different. It _might_ fix
> the nlm_grant_reply() bug as a side effect
It doesn't fix that on its own, but it might be a starting point.
> but that's already done by the small patch I posted earlier so...
Not completely. After your patch, for example, a failed attempt to
re-lock a region will result in the originally locked region being
unlocked.
> I think it is best to consider these issues separately.
>
> But I'm still unsure about who's picking up NLM patches and if server
> or client side matters.
I agree with Trond that this isn't the client's problem. I think if you
want to pursue this you should try modifying the server to get the
source ip address right. Post the patch here, and one of us will pick
it up.
--b.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
prev parent reply other threads:[~2007-07-03 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-29 15:52 NFSv3 locking bugs (trace+testprogram included) Frank van Maarseveen
2007-07-01 14:38 ` [PATCH] lockd: unlock when client rejects GRANTED_MSG Frank van Maarseveen
2007-07-01 14:58 ` J. Bruce Fields
2007-07-01 15:11 ` Frank van Maarseveen
2007-07-03 20:43 ` J. Bruce Fields
2007-07-03 20:53 ` J. Bruce Fields
2007-07-03 22:24 ` Frank van Maarseveen
2007-07-03 22:30 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070703223033.GG14074@fieldses.org \
--to=bfields@fieldses.org \
--cc=frankvm@frankvm.com \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.