From: Rodolfo Giometti <giometti@enneenne.com>
To: linux-kernel@vger.kernel.org
Subject: [RFC] disabling RTC irq during release
Date: Wed, 4 Jul 2007 19:07:53 +0200 [thread overview]
Message-ID: <20070704170753.GO10397@enneenne.com> (raw)
Hello,
Looking at other rtc drivers I noticed that during the release()
method we should disable IRQs as follow:
static void ds1307_release(struct device *dev)
{
struct ds1307 *ds1307 = dev_get_drvdata(dev);
if (ds1307->irq >= 0) {
ds1307->irqen = 0;
ds1307_update_alarm(ds1307);
}
}
that's the code I put into my patch for ds1339.
But if I wish using RTC IRQ line to turn also the board ON, not just
to put to sleep it, I should leave the IRQ line on!
I think we should add a configuration option who allows developers to
choose if the RTC IRQ line should be disabled or not during release().
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@gnudd.com
Embedded Systems giometti@linux.it
UNIX programming phone: +39 349 2432127
next reply other threads:[~2007-07-04 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 17:07 Rodolfo Giometti [this message]
2007-07-10 18:29 ` [RFC] disabling RTC irq during release David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070704170753.GO10397@enneenne.com \
--to=giometti@enneenne.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.