All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Handling of fault files in generic print code
Date: Thu, 05 Jul 2007 12:32:21 +0000	[thread overview]
Message-ID: <20070705143221.6a97fd5e@hyperion.delvare> (raw)
In-Reply-To: <468B2877.9010305@hhs.nl>

Hi Hans,

On Wed, 04 Jul 2007 06:56:23 +0200, Hans de Goede wrote:
> I noticed that currently the temp code prints a faults in the place where 
> normally an alarm gets printed, and ignores alarms. I mimicked this for the 
> fault support I added to the fan code.
> 
> But is this wise, since the reading are bogus when a FAULT is raised, shouldn't 
> the reading be omitted, just like were omitting the alarm?

I agree that the current implementation doesn't make much sense and
can be confusing to the users. The "FAULT" statement should replace the
(invalid) measured value rather than the ALARM flag. Can you please
propose a patch doing this?

Thanks,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2007-07-05 12:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-04  4:56 [lm-sensors] Handling of fault files in generic print code Hans de Goede
2007-07-05 12:32 ` Jean Delvare [this message]
2007-07-05 21:05 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070705143221.6a97fd5e@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.