From: Oleg Nesterov <oleg@tv-sign.ru>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 2/2] workqueue: debug work related deadlocks with lockdep
Date: Fri, 6 Jul 2007 16:53:24 +0400 [thread overview]
Message-ID: <20070706125324.GA74@tv-sign.ru> (raw)
In-Reply-To: <1183718633.3818.96.camel@johannes.berg>
On 07/06, Johannes Berg wrote:
>
> On Thu, 2007-07-05 at 19:36 +0400, Oleg Nesterov wrote:
>
> > So, __WORK_INITIALIZER() uses work_struct itself as a "struct lock_class_key" ?
> > How so?
>
> Well, this is for work_structs that are static (not dynamically
> allocated.) struct lock_class_key is just a single byte because its
> whole purpose is to be a unique pointer, there's nothing actually in it.
> Hence, taking the address of the work struct (when it's statically
> allocated) is a unique pointer just as well.
Yes, got it, but forgot to reply to myself. But thanks for your confirmation
of my understanding.
I believe both patches are nice.
Oleg.
next prev parent reply other threads:[~2007-07-06 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 11:07 [PATCH 0/2] workqueue lockup debugging Johannes Berg
2007-07-05 11:07 ` [PATCH 1/2] workqueue: debug flushing deadlocks with lockdep Johannes Berg
2007-07-05 14:32 ` Oleg Nesterov
2007-07-05 14:40 ` Ingo Molnar
2007-07-05 14:52 ` Oleg Nesterov
2007-07-06 10:42 ` Johannes Berg
2007-07-05 11:07 ` [PATCH 2/2] workqueue: debug work related " Johannes Berg
2007-07-05 15:36 ` Oleg Nesterov
2007-07-06 10:43 ` Johannes Berg
2007-07-06 12:53 ` Oleg Nesterov [this message]
2007-07-11 11:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070706125324.GA74@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.