From: Adrian Bunk <bunk@stusta.de>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] mm/vmstat.c: possible cleanups
Date: Fri, 6 Jul 2007 20:13:50 +0200 [thread overview]
Message-ID: <20070706181350.GO3492@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0707061048310.30575@schroedinger.engr.sgi.com>
On Fri, Jul 06, 2007 at 10:49:02AM -0700, Christoph Lameter wrote:
> On Fri, 6 Jul 2007, Adrian Bunk wrote:
>
> > This patch contains the following possible cleanups:
> > - make the needlessly global setup_vmstat() static
>
> Ok.
>
> > - #if 0 the unused refresh_vm_stats()
>
> Hmmm... This may be needed by the cpu idle code to update the vm stats
> before going idle.
Since 1 year it's making the kernel image larger without having a single
user.
And if it will one day get a user, removing the #if 0 will be trivial.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-07-06 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 23:23 [2.6 patch] mm/vmstat.c: possible cleanups Adrian Bunk
2007-07-06 17:49 ` Christoph Lameter
2007-07-06 18:13 ` Adrian Bunk [this message]
2007-07-06 19:21 ` Christoph Lameter
2007-07-09 14:57 ` [2.6 patch] mm/vmstat.c: cleanups Adrian Bunk
2007-07-09 15:44 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070706181350.GO3492@stusta.de \
--to=bunk@stusta.de \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.