From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Better generic print fault handling
Date: Sat, 07 Jul 2007 19:04:09 +0000 [thread overview]
Message-ID: <20070707210409.1e12476d@hyperion.delvare> (raw)
In-Reply-To: <20070707174935.7d4e56e4@hyperion.delvare>
On Sat, 07 Jul 2007 18:38:03 +0200, Hans de Goede wrote:
> Jean Delvare wrote:
> > I guess that the main problem here is that we have an artificial split
> > of temp_print_info() outside of the generic temperature printing
> > function, while we shouldn't. This explains in part why the this
> > generic temperature printing function doesn't look quite good.
>
> Hmm, I don't think putting all the temp_print_info() stuff into the function
> will make it better, maybe it will, but I don't know if a function becomes tom
> large splitting of small sub functions can be a good idea.
Agreed. But the number of arguments we are passing to temp_print_info()
right now clearly shows that something is wrong. Having everything in
the same file will make it easier to decide how to best split the code
between functions.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2007-07-07 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-07 15:49 [lm-sensors] Better generic print fault handling Jean Delvare
2007-07-07 16:38 ` Hans de Goede
2007-07-07 19:04 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070707210409.1e12476d@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.