[Cluster-devel] [2.6.22 regression fix] DLM must depend on SYSFS

[Cluster-devel] [2.6.22 regression fix] DLM must depend on SYSFS

[Adrian Bunk]

The dependency of DLM on SYSFS got lost in
commit 6ed7257b46709e87d79ac2b6b819b7e0c9184998 resulting in the 
following compile error with CONFIG_DLM=y, CONFIG_SYSFS=n:

<--  snip  -->

...
  LD      .tmp_vmlinux1
fs/built-in.o: In function `dlm_lockspace_init':
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc6-mm1/fs/dlm/lockspace.c:231: undefined reference to `kernel_subsys'
fs/built-in.o: In function `configfs_init':
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc6-mm1/fs/configfs/mount.c:143: undefined reference to `kernel_subsys'
make[1]: *** [.tmp_vmlinux1] Error 1

<--  snip  -->

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---
--- linux-2.6.22-rc6-mm1/fs/dlm/Kconfig.old	2007-07-07 06:07:10.000000000 +0200
+++ linux-2.6.22-rc6-mm1/fs/dlm/Kconfig	2007-07-07 06:07:26.000000000 +0200
@@ -3,7 +3,7 @@
 
 config DLM
 	tristate "Distributed Lock Manager (DLM)"
-	depends on IPV6 || IPV6=n
+	depends on SYSFS && (IPV6 || IPV6=n)
 	select CONFIGFS_FS
 	select IP_SCTP
 	help

[2.6.22 regression fix] DLM must depend on SYSFS

[Adrian Bunk]

The dependency of DLM on SYSFS got lost in
commit 6ed7257b46709e87d79ac2b6b819b7e0c9184998 resulting in the 
following compile error with CONFIG_DLM=y, CONFIG_SYSFS=n:

<--  snip  -->

...
  LD      .tmp_vmlinux1
fs/built-in.o: In function `dlm_lockspace_init':
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc6-mm1/fs/dlm/lockspace.c:231: undefined reference to `kernel_subsys'
fs/built-in.o: In function `configfs_init':
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc6-mm1/fs/configfs/mount.c:143: undefined reference to `kernel_subsys'
make[1]: *** [.tmp_vmlinux1] Error 1

<--  snip  -->

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---
--- linux-2.6.22-rc6-mm1/fs/dlm/Kconfig.old	2007-07-07 06:07:10.000000000 +0200
+++ linux-2.6.22-rc6-mm1/fs/dlm/Kconfig	2007-07-07 06:07:26.000000000 +0200
@@ -3,7 +3,7 @@
 
 config DLM
 	tristate "Distributed Lock Manager (DLM)"
-	depends on IPV6 || IPV6=n
+	depends on SYSFS && (IPV6 || IPV6=n)
 	select CONFIGFS_FS
 	select IP_SCTP
 	help

Re: [2.6.22 regression fix] DLM must depend on SYSFS

[Linus Torvalds]

On Sat, 7 Jul 2007, Adrian Bunk wrote:
>
> The dependency of DLM on SYSFS got lost in
> commit 6ed7257b46709e87d79ac2b6b819b7e0c9184998 resulting in the 
> following compile error with CONFIG_DLM=y, CONFIG_SYSFS=n:

Hmm. Shouldn't we make that a "select", the way we already do for 
CONFIGFS_FS? 

		Linus

[Cluster-devel] Re: [2.6.22 regression fix] DLM must depend on SYSFS

[Adrian Bunk]

On Sat, Jul 07, 2007 at 01:51:55PM -0700, Linus Torvalds wrote:
> 
> 
> On Sat, 7 Jul 2007, Adrian Bunk wrote:
> >
> > The dependency of DLM on SYSFS got lost in
> > commit 6ed7257b46709e87d79ac2b6b819b7e0c9184998 resulting in the 
> > following compile error with CONFIG_DLM=y, CONFIG_SYSFS=n:
> 
> Hmm. Shouldn't we make that a "select", the way we already do for 
> CONFIGFS_FS? 

"select" is more user friendly while "depends on" makes it easier to 
disable options.

Usually I'm for the usage of "select" in such cases, but since this is 
with CONFIG_EMBEDDED=y where users can be expected to know better what 
they are doing I'd say a "depends on" is fine.

CONFIGFS_FS as a helper for some few file systems is also a different 
situation from SYSFS that is a dependency of much more options.

> 		Linus

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6.22 regression fix] DLM must depend on SYSFS

[Adrian Bunk]

On Sat, Jul 07, 2007 at 01:51:55PM -0700, Linus Torvalds wrote:
> 
> 
> On Sat, 7 Jul 2007, Adrian Bunk wrote:
> >
> > The dependency of DLM on SYSFS got lost in
> > commit 6ed7257b46709e87d79ac2b6b819b7e0c9184998 resulting in the 
> > following compile error with CONFIG_DLM=y, CONFIG_SYSFS=n:
> 
> Hmm. Shouldn't we make that a "select", the way we already do for 
> CONFIGFS_FS? 

"select" is more user friendly while "depends on" makes it easier to 
disable options.

Usually I'm for the usage of "select" in such cases, but since this is 
with CONFIG_EMBEDDED=y where users can be expected to know better what 
they are doing I'd say a "depends on" is fine.

CONFIGFS_FS as a helper for some few file systems is also a different 
situation from SYSFS that is a dependency of much more options.

> 		Linus

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6.22 regression fix] DLM must depend on SYSFS

[Linus Torvalds]

On Sat, 7 Jul 2007, Adrian Bunk wrote:
> 
> Usually I'm for the usage of "select" in such cases, but since this is 
> with CONFIG_EMBEDDED=y where users can be expected to know better what 
> they are doing I'd say a "depends on" is fine.

Fair enough.

		Linus